From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08AFFC04AB6 for ; Fri, 31 May 2019 17:45:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DD72526D50 for ; Fri, 31 May 2019 17:45:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726666AbfEaRpM (ORCPT ); Fri, 31 May 2019 13:45:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45154 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726653AbfEaRpM (ORCPT ); Fri, 31 May 2019 13:45:12 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F7E66EBA1; Fri, 31 May 2019 17:45:12 +0000 (UTC) Received: from localhost (ovpn-204-38.brq.redhat.com [10.40.204.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 747AA19C69; Fri, 31 May 2019 17:45:11 +0000 (UTC) References: <20190529160337.4672-1-plautrba@redhat.com> User-agent: mu4e 1.2.0; emacs 26.2 From: Petr Lautrbach To: Paul Moore Cc: Petr Lautrbach , selinux@vger.kernel.org Subject: Re: [PATCH] Add CONTRIBUTING In-reply-to: Date: Fri, 31 May 2019 19:45:09 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 31 May 2019 17:45:12 +0000 (UTC) Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org Paul Moore writes: > On Wed, May 29, 2019 at 12:05 PM Paul Moore wrote: >> On Wed, May 29, 2019 at 12:03 PM Petr Lautrbach wrote: >> > >> > Based on https://github.com/SELinuxProject/selinux/wiki/Contributing >> > >> > Signed-off-by: Petr Lautrbach >> > --- >> > CONTRIBUTING | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++ >> > 1 file changed, 60 insertions(+) >> > create mode 100644 CONTRIBUTING >> >> I would suggest updating the wiki to point to this file if/when it is >> merged upstream. > > Sorry, one more thing: you might consider adding the ".md" suffix so > that GitHub and others will treat it as Markdown. I know that GitHub > also treats the CONTRIBUTING.md file in a special way and presents it > to users in various parts of the web UI, for example it show up in the > sidebar when creating new issues. Using Contributing.md in code would mean that it could be directly copied to wiki. When you say include DCO directly in Contributing, do you mean something like https://github.com/bachradsusi/SELinuxProject-selinux/wiki/Contributing ? Petr