From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45FF5C87FD1 for ; Tue, 5 Aug 2025 09:50:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=q7lVLJ9hWEXhXKWOSLKrEYr0hltxzVzy6g/YmUKVWXE=; b=Gt1O1LLMc7SYOq ZFAzqGdNvMEQMXA/p7D5N+Fupz2E0ht2NWVMn3/243lscYgmVbdaPaMW3O5aLq/VaAIxepwYUqpUf 5mo44kQIvLhaajibuqFoanwYVz7qjKy5lvMN8OjRPSfrEJiWIiHoWT/HsIk+X+3zKKtaIqLR/9HZo E7RkToLNF5+DnjdzNTzP9w6K/vsOv5Pl4+7ZwgkRu0lda9FGYbQSJcZ0x+ES0cOc5+qwzvmyMQGYD xcHFfQiPWvc1+08lYf+LW+uu/7m4QFOllRSaEQkmHWv7LRK3YWTdiPcuIN3ckdUj3hkr/FrBQrjmt fssJdIM1dmdEpZOnW4WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ujEJ4-0000000CPpH-2Q2K; Tue, 05 Aug 2025 09:50:06 +0000 Received: from mail-francesouthazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c207::3] helo=MRWPR03CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ujE3O-0000000CMof-3slM; Tue, 05 Aug 2025 09:33:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sixmxPrwf6xEPzzSTtnvsbnT0WfwumUJJkU7JiNq3IouPpv+qpYZTVw61+IbPcITT3qDUMcbX7XXeQcCsaDLiuvKEJXUnchhYEC1TaNHNzFIgU3IlEMwqOdRuI81XflkI2Qc+OHH7i1ZcahxfnZV26osreRofHVjK65ZllKAeX93dbLW3Tr9rcE9NQik4r28u+aQzYikS3QaVNYGmGDG1/ddHPuDaptigCD4DUZxnSNJKolMKBMz2X3vMdgoIqP5WI7aB3wIZ77VyAttpn/sm10jRHoK8XMj/ZR4qZp1UW785PpyH9C0afMmGwxduXwF153QldpqAfLAnGm68++orw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ESZC5HuzW3y0dHX6V2ROjo90VnZp5KQFMHICcVIIvWs=; b=HFq7x0FlvkthjkmMH1F/jn4p4zwKjZ5zOXRulsOqtP9W+7FqUd5CeqPLTPzVk9u6FIPA1Ctox2OQTnb8izOcEXfmQVB3TIXFZAnRZTRH6J9q4AZQIbVq7ZXuH29EXwy2L/L7cqtADrBsxlp/lVfy/+vFK8zgIVVPlFVu5fWDwfwcQNO1WTAsD20V81x+0xeFUAworhXhSzVjvgTWDjaJh4GYmJpxkpj3bonTL88BLvxS9hGrJ7m0PAZ2FGbVKFQwywFnRPX3NfgVYQVaUW9Um54jBuJPK9wdoeXbosQrtklE6oxbAlLcLxJ0wyYRj1fCqos8G6Gvt6tGTUx6liBUnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 195.60.68.100) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=axis.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ESZC5HuzW3y0dHX6V2ROjo90VnZp5KQFMHICcVIIvWs=; b=RbYJUtyfudOqvgj1M2d4PS+mZILKHownpHsS7MAwitS4tWjmNhw5vSGwGMoIz73cNH4BG2HcEL/6zT0pGdAZU4Jf+XNuYkKXAHcG30cC34iMIPhI/ZusB1M6clbEzRoM0JfHXj6W5vZ4tV3FGtMoYJb3oePK554rqWGECQjE/Tw= Received: from AS4PR09CA0010.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::14) by DB4PR02MB9647.eurprd02.prod.outlook.com (2603:10a6:10:3f1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.20; Tue, 5 Aug 2025 09:33:47 +0000 Received: from AM3PEPF0000A791.eurprd04.prod.outlook.com (2603:10a6:20b:5e0:cafe::a9) by AS4PR09CA0010.outlook.office365.com (2603:10a6:20b:5e0::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9009.13 via Frontend Transport; Tue, 5 Aug 2025 09:33:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=axis.com; Received-SPF: Pass (protection.outlook.com: domain of axis.com designates 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; pr=C Received: from mail.axis.com (195.60.68.100) by AM3PEPF0000A791.mail.protection.outlook.com (10.167.16.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9009.8 via Frontend Transport; Tue, 5 Aug 2025 09:33:45 +0000 Received: from pc52311-2249 (10.4.0.13) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Tue, 5 Aug 2025 11:33:36 +0200 From: Waqar Hameed To: =?utf-8?Q?Uwe_Kleine-K=C3=B6nig?= , Neil Armstrong , Kevin Hilman , "Jerome Brunet" , Martin Blumenstingl CC: , , , , Subject: [PATCH v2] pwm: meson: Remove error print for devm_add_action_or_reset() User-Agent: a.out Date: Tue, 5 Aug 2025 11:33:36 +0200 Message-ID: MIME-Version: 1.0 X-Originating-IP: [10.4.0.13] X-ClientProxiedBy: se-mail02w.axis.com (10.20.40.8) To se-mail01w.axis.com (10.20.40.7) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF0000A791:EE_|DB4PR02MB9647:EE_ X-MS-Office365-Filtering-Correlation-Id: f170bb5a-9abd-464c-d166-08ddd4032ce0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?djxbEymfbn9/jPUfsmPsXSfGkbqYq+LJHC5pSA66/8jNoSL3s8EU6gmv4jF/?= =?us-ascii?Q?vLYmcnaZz7V9ofntREqlTTlgF6O3Kg3jldtDxYJ+zWurgrh7vpz0RyCLLmnt?= =?us-ascii?Q?TaNqG7QCOy+ReE2HhjUdpiddF7KMddkhQ2Kctseovff1UM6XQ18dkKqqKdfU?= =?us-ascii?Q?gnCh2jJBGKECu2Y8l8NM18V73PBfzwHBeI+uLb76BiVRaz/5veNEOObDfm9w?= =?us-ascii?Q?izSptRaqWa8ehuV3UF2qZKEfQ0/jpScRmFJagadFQ0qjWJDUFSNCg8Ci65Xh?= =?us-ascii?Q?+Sz+TV9bOqwyW3ZdiMCH/SmiefZPOTo7xyIVmQBqe59k/ArM3UE5ebAfZQub?= =?us-ascii?Q?zDgP3u+dYLR3YUsYX1SYVsds9ZOARyPR9ZgPdTQuNRHxA8UbCKTLIXaVEE8H?= =?us-ascii?Q?0lg8+gJgIKQ5wcTwS2bBj5BrJ5MqvM0tPXM8wQ+5XZfZtvmeiygn2H3/NKJL?= =?us-ascii?Q?HkLcs4nxDEw8TnHFsHMWmCrJYNkqHW3To9MTPm/k6I2q93T2Ard3r6OrBbch?= =?us-ascii?Q?Zsejv/MOUzXPPYlKYKr6BqIcLvYrxe+eK0gxHE7VAptHwzU3kiYtZmwowWR0?= =?us-ascii?Q?po76licq/F7H0VHn3ZB/dwyljbyOmzp8e3plPnGKa6e7QiX60bm29duGn49c?= =?us-ascii?Q?6yxEYkM3x514nqAjlkKPXfOEeuePTOP84MEllRQ8eED9BHMTUxXxV1DT3Sd3?= =?us-ascii?Q?7DwOzLaTGzH2yFMhN95K/tD1ildrueXgJAvuS9qXZkWtcdE0PTrZ6AVRy5v0?= =?us-ascii?Q?miB6pVxQP5eNrpgZWsOQ7TXiPasf3T8i//+HxD4wZdtFshWbTYLYdb7W24td?= =?us-ascii?Q?j33ZHPsr9wNJZqY4WJVA9d9tKdUCJvvF5bTwWCANNL6yKXM4c6g3Za/Xog8X?= =?us-ascii?Q?Zcral0XWEauQjZgYHBErCyMWo7RyhbKJccA4YSH9PA7vOCKUYt6nIEqd9ghG?= =?us-ascii?Q?v4eLDqUBNymQHpBZgip5zkzc7VllMpawmBDxjkyxEf40jlfAymSGBBQnVMjW?= =?us-ascii?Q?vW/CTeoia10OcucWezB7ioi7hT9SD/2UbQk7KwtmA2e+egaa/oMVFJQnzuUz?= =?us-ascii?Q?6tY6EPG8DlvKR9HbPClc3rXLMMXY/p8C/0sT/iBA8WTEQB1myEjjzWB2o4X2?= =?us-ascii?Q?JcIYcesZqTaWQHTKPQOs4ZK5uO+9ke1pJ0phGDbCHCWjVRaoMpe1EFB/zcEm?= =?us-ascii?Q?erebP7jT5rPjIDy+wP5uO+VRmby9gkr99aH10a/dm0rNTeZMXpdf/X8QuD2i?= =?us-ascii?Q?u+WEhQpDarsvZlIlewtbPF0+Oy9Ds1rS6xhEPeYivZQyteKaOLmQxGb7s+fS?= =?us-ascii?Q?XT/mDEXp4fvZQHn1I1S9idnqpyj3+XZ2USi4X2c8txZVZ8CuPW9IJnxvnctv?= =?us-ascii?Q?7/c/vqXMUeqYgFVT8v1HpgNK1z+lXEDIDBEU1Frsen4bUzH+nt6Z8RKdJ7Ac?= =?us-ascii?Q?wPiSnh7/1FDuIiZJakMKtqD36f56fsg6g4J9agOgbI8mZ/VysJipuGF5Wp5D?= =?us-ascii?Q?5P1LSWKKvxjtCbow7Y+ejBs3LkcOfMV88WGv?= X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2025 09:33:45.8967 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f170bb5a-9abd-464c-d166-08ddd4032ce0 X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A791.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB9647 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250805_023355_000144_1AD9268A X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org When `devm_add_action_or_reset()` fails, it is due to a failed memory allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do anything when error is `-ENOMEM`. Therefore, remove the useless call to `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just return the value instead. Signed-off-by: Waqar Hameed --- Changes in v2: * Split the patch to one seperate patch for each sub-system. Link to v1: https://lore.kernel.org/all/pnd7c0s6ji2.fsf@axis.com/ drivers/pwm/pwm-meson.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c index 8c6bf3d49753..e90d37d4f956 100644 --- a/drivers/pwm/pwm-meson.c +++ b/drivers/pwm/pwm-meson.c @@ -520,8 +520,7 @@ static int meson_pwm_init_channels_s4(struct pwm_chip *chip) ret = devm_add_action_or_reset(dev, meson_pwm_s4_put_clk, meson->channels[i].clk); if (ret) - return dev_err_probe(dev, ret, - "Failed to add clk_put action\n"); + return ret; } return 0; base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2 -- 2.39.5 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0E24C87FD1 for ; Tue, 5 Aug 2025 09:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=ESZC5HuzW3y0dHX6V2ROjo90VnZp5KQFMHICcVIIvWs=; b=zzmmiVsaDLi+9a+VjhzW6D7ew2 c1gQYWxj36KEY8jVi4fQheGU3CXHDHUleo7zTKZnoBekEfD3zyrCcA7ivKceW0skJPlb0n+eB2KmT j4d2v0mY0TbWSl83BE9Y7WNW8tCe2c6iasVEoSaFWIbY80mhdfdl1JgDWemA4YJLZkvUbIQvI2UtX Fi94R1Es/vAGs5vKSt9zYxYt0/AYLUcAADMKzZ4NmzaBGxJ+EPB24Lu91ixDUqNezDqpHKTjceZkm HPER03UmsoVO2pK6wx91+Mcpozc/OFJt9nYQ+U0HPq2Bp/EafaIxSqBA3m+TgBzg5yKu9xmMytCIC SzV0+2Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ujELc-0000000CQBF-3FNL; Tue, 05 Aug 2025 09:52:44 +0000 Received: from mail-francesouthazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c207::3] helo=MRWPR03CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ujE3O-0000000CMof-3slM; Tue, 05 Aug 2025 09:33:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sixmxPrwf6xEPzzSTtnvsbnT0WfwumUJJkU7JiNq3IouPpv+qpYZTVw61+IbPcITT3qDUMcbX7XXeQcCsaDLiuvKEJXUnchhYEC1TaNHNzFIgU3IlEMwqOdRuI81XflkI2Qc+OHH7i1ZcahxfnZV26osreRofHVjK65ZllKAeX93dbLW3Tr9rcE9NQik4r28u+aQzYikS3QaVNYGmGDG1/ddHPuDaptigCD4DUZxnSNJKolMKBMz2X3vMdgoIqP5WI7aB3wIZ77VyAttpn/sm10jRHoK8XMj/ZR4qZp1UW785PpyH9C0afMmGwxduXwF153QldpqAfLAnGm68++orw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ESZC5HuzW3y0dHX6V2ROjo90VnZp5KQFMHICcVIIvWs=; b=HFq7x0FlvkthjkmMH1F/jn4p4zwKjZ5zOXRulsOqtP9W+7FqUd5CeqPLTPzVk9u6FIPA1Ctox2OQTnb8izOcEXfmQVB3TIXFZAnRZTRH6J9q4AZQIbVq7ZXuH29EXwy2L/L7cqtADrBsxlp/lVfy/+vFK8zgIVVPlFVu5fWDwfwcQNO1WTAsD20V81x+0xeFUAworhXhSzVjvgTWDjaJh4GYmJpxkpj3bonTL88BLvxS9hGrJ7m0PAZ2FGbVKFQwywFnRPX3NfgVYQVaUW9Um54jBuJPK9wdoeXbosQrtklE6oxbAlLcLxJ0wyYRj1fCqos8G6Gvt6tGTUx6liBUnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 195.60.68.100) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=axis.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=axis.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ESZC5HuzW3y0dHX6V2ROjo90VnZp5KQFMHICcVIIvWs=; b=RbYJUtyfudOqvgj1M2d4PS+mZILKHownpHsS7MAwitS4tWjmNhw5vSGwGMoIz73cNH4BG2HcEL/6zT0pGdAZU4Jf+XNuYkKXAHcG30cC34iMIPhI/ZusB1M6clbEzRoM0JfHXj6W5vZ4tV3FGtMoYJb3oePK554rqWGECQjE/Tw= Received: from AS4PR09CA0010.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::14) by DB4PR02MB9647.eurprd02.prod.outlook.com (2603:10a6:10:3f1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8989.20; Tue, 5 Aug 2025 09:33:47 +0000 Received: from AM3PEPF0000A791.eurprd04.prod.outlook.com (2603:10a6:20b:5e0:cafe::a9) by AS4PR09CA0010.outlook.office365.com (2603:10a6:20b:5e0::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9009.13 via Frontend Transport; Tue, 5 Aug 2025 09:33:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 195.60.68.100) smtp.mailfrom=axis.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=axis.com; Received-SPF: Pass (protection.outlook.com: domain of axis.com designates 195.60.68.100 as permitted sender) receiver=protection.outlook.com; client-ip=195.60.68.100; helo=mail.axis.com; pr=C Received: from mail.axis.com (195.60.68.100) by AM3PEPF0000A791.mail.protection.outlook.com (10.167.16.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.9009.8 via Frontend Transport; Tue, 5 Aug 2025 09:33:45 +0000 Received: from pc52311-2249 (10.4.0.13) by se-mail01w.axis.com (10.20.40.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Tue, 5 Aug 2025 11:33:36 +0200 From: Waqar Hameed To: =?utf-8?Q?Uwe_Kleine-K=C3=B6nig?= , Neil Armstrong , Kevin Hilman , "Jerome Brunet" , Martin Blumenstingl CC: , , , , Subject: [PATCH v2] pwm: meson: Remove error print for devm_add_action_or_reset() User-Agent: a.out Date: Tue, 5 Aug 2025 11:33:36 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.4.0.13] X-ClientProxiedBy: se-mail02w.axis.com (10.20.40.8) To se-mail01w.axis.com (10.20.40.7) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF0000A791:EE_|DB4PR02MB9647:EE_ X-MS-Office365-Filtering-Correlation-Id: f170bb5a-9abd-464c-d166-08ddd4032ce0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?djxbEymfbn9/jPUfsmPsXSfGkbqYq+LJHC5pSA66/8jNoSL3s8EU6gmv4jF/?= =?us-ascii?Q?vLYmcnaZz7V9ofntREqlTTlgF6O3Kg3jldtDxYJ+zWurgrh7vpz0RyCLLmnt?= =?us-ascii?Q?TaNqG7QCOy+ReE2HhjUdpiddF7KMddkhQ2Kctseovff1UM6XQ18dkKqqKdfU?= =?us-ascii?Q?gnCh2jJBGKECu2Y8l8NM18V73PBfzwHBeI+uLb76BiVRaz/5veNEOObDfm9w?= =?us-ascii?Q?izSptRaqWa8ehuV3UF2qZKEfQ0/jpScRmFJagadFQ0qjWJDUFSNCg8Ci65Xh?= =?us-ascii?Q?+Sz+TV9bOqwyW3ZdiMCH/SmiefZPOTo7xyIVmQBqe59k/ArM3UE5ebAfZQub?= =?us-ascii?Q?zDgP3u+dYLR3YUsYX1SYVsds9ZOARyPR9ZgPdTQuNRHxA8UbCKTLIXaVEE8H?= =?us-ascii?Q?0lg8+gJgIKQ5wcTwS2bBj5BrJ5MqvM0tPXM8wQ+5XZfZtvmeiygn2H3/NKJL?= =?us-ascii?Q?HkLcs4nxDEw8TnHFsHMWmCrJYNkqHW3To9MTPm/k6I2q93T2Ard3r6OrBbch?= =?us-ascii?Q?Zsejv/MOUzXPPYlKYKr6BqIcLvYrxe+eK0gxHE7VAptHwzU3kiYtZmwowWR0?= =?us-ascii?Q?po76licq/F7H0VHn3ZB/dwyljbyOmzp8e3plPnGKa6e7QiX60bm29duGn49c?= =?us-ascii?Q?6yxEYkM3x514nqAjlkKPXfOEeuePTOP84MEllRQ8eED9BHMTUxXxV1DT3Sd3?= =?us-ascii?Q?7DwOzLaTGzH2yFMhN95K/tD1ildrueXgJAvuS9qXZkWtcdE0PTrZ6AVRy5v0?= =?us-ascii?Q?miB6pVxQP5eNrpgZWsOQ7TXiPasf3T8i//+HxD4wZdtFshWbTYLYdb7W24td?= =?us-ascii?Q?j33ZHPsr9wNJZqY4WJVA9d9tKdUCJvvF5bTwWCANNL6yKXM4c6g3Za/Xog8X?= =?us-ascii?Q?Zcral0XWEauQjZgYHBErCyMWo7RyhbKJccA4YSH9PA7vOCKUYt6nIEqd9ghG?= =?us-ascii?Q?v4eLDqUBNymQHpBZgip5zkzc7VllMpawmBDxjkyxEf40jlfAymSGBBQnVMjW?= =?us-ascii?Q?vW/CTeoia10OcucWezB7ioi7hT9SD/2UbQk7KwtmA2e+egaa/oMVFJQnzuUz?= =?us-ascii?Q?6tY6EPG8DlvKR9HbPClc3rXLMMXY/p8C/0sT/iBA8WTEQB1myEjjzWB2o4X2?= =?us-ascii?Q?JcIYcesZqTaWQHTKPQOs4ZK5uO+9ke1pJ0phGDbCHCWjVRaoMpe1EFB/zcEm?= =?us-ascii?Q?erebP7jT5rPjIDy+wP5uO+VRmby9gkr99aH10a/dm0rNTeZMXpdf/X8QuD2i?= =?us-ascii?Q?u+WEhQpDarsvZlIlewtbPF0+Oy9Ds1rS6xhEPeYivZQyteKaOLmQxGb7s+fS?= =?us-ascii?Q?XT/mDEXp4fvZQHn1I1S9idnqpyj3+XZ2USi4X2c8txZVZ8CuPW9IJnxvnctv?= =?us-ascii?Q?7/c/vqXMUeqYgFVT8v1HpgNK1z+lXEDIDBEU1Frsen4bUzH+nt6Z8RKdJ7Ac?= =?us-ascii?Q?wPiSnh7/1FDuIiZJakMKtqD36f56fsg6g4J9agOgbI8mZ/VysJipuGF5Wp5D?= =?us-ascii?Q?5P1LSWKKvxjtCbow7Y+ejBs3LkcOfMV88WGv?= X-Forefront-Antispam-Report: CIP:195.60.68.100;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.axis.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: axis.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2025 09:33:45.8967 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f170bb5a-9abd-464c-d166-08ddd4032ce0 X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=78703d3c-b907-432f-b066-88f7af9ca3af;Ip=[195.60.68.100];Helo=[mail.axis.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A791.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR02MB9647 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250805_023355_000144_1AD9268A X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When `devm_add_action_or_reset()` fails, it is due to a failed memory allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do anything when error is `-ENOMEM`. Therefore, remove the useless call to `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just return the value instead. Signed-off-by: Waqar Hameed --- Changes in v2: * Split the patch to one seperate patch for each sub-system. Link to v1: https://lore.kernel.org/all/pnd7c0s6ji2.fsf@axis.com/ drivers/pwm/pwm-meson.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c index 8c6bf3d49753..e90d37d4f956 100644 --- a/drivers/pwm/pwm-meson.c +++ b/drivers/pwm/pwm-meson.c @@ -520,8 +520,7 @@ static int meson_pwm_init_channels_s4(struct pwm_chip *chip) ret = devm_add_action_or_reset(dev, meson_pwm_s4_put_clk, meson->channels[i].clk); if (ret) - return dev_err_probe(dev, ret, - "Failed to add clk_put action\n"); + return ret; } return 0; base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2 -- 2.39.5