All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Derrick Stolee <dstolee@microsoft.com>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH 0/2] pull: release handles to pack files before potentially gc'ing
Date: Wed, 08 Sep 2021 08:29:29 +0000	[thread overview]
Message-ID: <pull.1032.git.1631089771.gitgitgadget@gmail.com> (raw)

It was reported in Git for Windows
[https://github.com/git-for-windows/git/issues/3336] that there are still
some code paths where .pack files are still open when a garbage collection
is triggered. This time, the affected command is git pull.

The fix is relatively trivial but uncovers a bug in the commit-graph code,
which we have to fix first.

Johannes Schindelin (2):
  commit-graph: when closing the graph, also release the slab
  pull: release packs before fetching

 builtin/pull.c | 2 ++
 commit-graph.c | 1 +
 2 files changed, 3 insertions(+)


base-commit: 225bc32a989d7a22fa6addafd4ce7dcd04675dbf
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1032%2Fdscho%2Frelease-packs-before-fetching-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1032/dscho/release-packs-before-fetching-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1032
-- 
gitgitgadget

             reply	other threads:[~2021-09-08  8:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08  8:29 Johannes Schindelin via GitGitGadget [this message]
2021-09-08  8:29 ` [PATCH 1/2] commit-graph: when closing the graph, also release the slab Johannes Schindelin via GitGitGadget
2021-09-08  8:29 ` [PATCH 2/2] pull: release packs before fetching Johannes Schindelin via GitGitGadget
2021-09-08 19:16   ` Junio C Hamano
2021-09-09 11:20     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1032.git.1631089771.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.