All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] Fix incorrectly reported CPU in 32-bit Windows
Date: Thu, 07 Feb 2019 02:46:05 -0800 (PST)	[thread overview]
Message-ID: <pull.121.git.gitgitgadget@gmail.com> (raw)

While in review, Git for Windows' original design was changed, to use the
output of uname -m instead of (necessarily incomplete) pre-processor magic
to determine which CPU to report.

Both 32-bit and 64-bit versions of Git for Windows are built in the 64-bit
Git for Windows SDK, however, whose uname -m always reports x86_64. Even for
32-bit Git for Windows.

Let's fix that by going back to the pre-processor magic, making it specific
to Git for Windows' SDK (where it actually is complete).

This is yet another patch I forgot to upstream, and I hope that it will make
it into v2.21.0-rc1.

Johannes Schindelin (1):
  mingw: fix CPU reporting in `git version --build-options`

 compat/mingw.h | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)


base-commit: d62dad7a7dca3f6a65162bf0e52cdf6927958e78
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-121%2Fdscho%2Fmingw-build-options-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-121/dscho/mingw-build-options-fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/121
-- 
gitgitgadget

             reply	other threads:[~2019-02-07 10:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 10:46 Johannes Schindelin via GitGitGadget [this message]
2019-02-07 10:46 ` [PATCH 1/1] mingw: fix CPU reporting in `git version --build-options` Johannes Schindelin via GitGitGadget
2019-02-08 22:39   ` Eric Sunshine
2019-02-13  9:59     ` Johannes Schindelin
2019-02-07 21:13 ` [PATCH 0/1] Fix incorrectly reported CPU in 32-bit Windows Junio C Hamano
2019-02-07 22:41   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.121.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.