From: "mataha via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: mataha <mateusz.kazimierczuk@xolv.io>,
mataha <mateusz.kazimierczuk@xolv.io>
Subject: [PATCH] templates: clarify SHA1 arg in prepare-commit-msg
Date: Wed, 18 May 2022 18:40:19 +0000 [thread overview]
Message-ID: <pull.1265.git.git.1652899219597.gitgitgadget@gmail.com> (raw)
From: mataha <mateusz.kazimierczuk@xolv.io>
'prepare-commit-msg' hook sample description doesn't mention the third
argument (a commit object name) nor when is it actually passed to that
hook by git-commit (if the source is a commit; see builtin/commit.c#L777,
sequencer.c#L1219). Seeing that it's documented in githooks(5), there
should be no reason not to include that in the sample hook as well.
Signed-off-by: Mateusz 'mataha' Kazimierczuk <mateusz.kazimierczuk@xolv.io>
---
Mention the third argument in 'prepare-commit-msg' hook sample
'prepare-commit-msg' hook sample doesn't mention what the third argument
is for nor when is it actually passed; I feel like it should be, for the
sake of convenience (this doesn't mean that a user shouldn't refer to a
more detailed description in the manual, of course).
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1265%2Fmataha%2Fdoc%2Fprepare-commit-msg-args-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1265/mataha/doc/prepare-commit-msg-args-v1
Pull-Request: https://github.com/git/git/pull/1265
templates/hooks--prepare-commit-msg.sample | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/templates/hooks--prepare-commit-msg.sample b/templates/hooks--prepare-commit-msg.sample
index 318afe3fd86..bc06d0701a8 100755
--- a/templates/hooks--prepare-commit-msg.sample
+++ b/templates/hooks--prepare-commit-msg.sample
@@ -3,9 +3,9 @@
# An example hook script to prepare the commit log message.
# Called by "git commit" with the name of the file that has the
# commit message, followed by the description of the commit
-# message's source. The hook's purpose is to edit the commit
-# message file. If the hook fails with a non-zero status,
-# the commit is aborted.
+# message's source and the commit object name (if the source was
+# a commit). The hook's purpose is to edit the commit message file.
+# If the hook fails with a non-zero status, the commit is aborted.
#
# To enable this hook, rename this file to "prepare-commit-msg".
base-commit: 277cf0bc36094f6dc4297d8c9cef79df045b735d
--
gitgitgadget
next reply other threads:[~2022-05-18 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 18:40 mataha via GitGitGadget [this message]
2022-05-18 18:58 ` [PATCH] templates: clarify SHA1 arg in prepare-commit-msg Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1265.git.git.1652899219597.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=mateusz.kazimierczuk@xolv.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.