From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] mingw: handle non-ASCII PATH components correctly
Date: Sat, 24 Aug 2019 15:38:55 -0700 (PDT) [thread overview]
Message-ID: <pull.135.git.gitgitgadget@gmail.com> (raw)
We need to be careful on Windows: there are "ANSI" versions of the API
functions that take char *, and "Unicode" versions that take "wchar_t `
strings as parameters. The ANSI versions are subject to the current
codepage, i.e. almost guaranteed to *not handle UTF-8. Internally, we do
want to use UTF-8, though, at least in compat/mingw.c, so we really have to
use the Unicode versions of the Win32 API.
Adam Roben (1):
mingw: fix launching of externals from Unicode paths
compat/mingw.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
base-commit: 8104ec994ea3849a968b4667d072fedd1e688642
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-135%2Fdscho%2Ffix-externals-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-135/dscho/fix-externals-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/135
--
gitgitgadget
next reply other threads:[~2019-08-24 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 22:38 Johannes Schindelin via GitGitGadget [this message]
2019-08-24 22:38 ` [PATCH 1/1] mingw: fix launching of externals from Unicode paths Adam Roben via GitGitGadget
2019-08-26 17:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.135.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.