From: "M Hickford via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: M Hickford <mirth.hickford@gmail.com>,
M Hickford <mirth.hickford@gmail.com>
Subject: [PATCH] docs: clarify that credential discards unrecognised attributes
Date: Mon, 24 Oct 2022 07:57:48 +0000 [thread overview]
Message-ID: <pull.1393.git.1666598268697.gitgitgadget@gmail.com> (raw)
From: M Hickford <mirth.hickford@gmail.com>
It was previously unclear how unrecognised attributes are handled.
Signed-off-by: M Hickford <mirth.hickford@gmail.com>
---
docs: clarify that credential discards unrecognised attributes
It was previously unclear how unrecognised attributes are handled.
Signed-off-by: M Hickford mirth.hickford@gmail.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1393%2Fhickford%2Funrecognised-attributes-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1393/hickford/unrecognised-attributes-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1393
Documentation/git-credential.txt | 2 ++
Documentation/gitcredentials.txt | 1 +
2 files changed, 3 insertions(+)
diff --git a/Documentation/git-credential.txt b/Documentation/git-credential.txt
index f18673017f5..ac2818b9f66 100644
--- a/Documentation/git-credential.txt
+++ b/Documentation/git-credential.txt
@@ -160,6 +160,8 @@ empty string.
Components which are missing from the URL (e.g., there is no
username in the example above) will be left unset.
+Unrecognised attributes are silently discarded.
+
GIT
---
Part of the linkgit:git[1] suite
diff --git a/Documentation/gitcredentials.txt b/Documentation/gitcredentials.txt
index 80517b4eb2c..e856e3c8330 100644
--- a/Documentation/gitcredentials.txt
+++ b/Documentation/gitcredentials.txt
@@ -269,6 +269,7 @@ stdout in the same format (see linkgit:git-credential[1] for common
attributes). A helper is free to produce a subset, or even no values at
all if it has nothing useful to provide. Any provided attributes will
overwrite those already known about by Git's credential subsystem.
+Unrecognised attributes are silently discarded.
While it is possible to override all attributes, well behaving helpers
should refrain from doing so for any attribute other than username and
base-commit: 1fc3c0ad407008c2f71dd9ae1241d8b75f8ef886
--
gitgitgadget
next reply other threads:[~2022-10-24 7:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 7:57 M Hickford via GitGitGadget [this message]
2022-10-24 23:59 ` [PATCH] docs: clarify that credential discards unrecognised attributes Jeff King
2022-10-25 0:00 ` Jeff King
2022-10-25 1:51 ` Thanks M Hickford
2022-10-25 9:05 ` Thanks Bagas Sanjaya
2022-10-26 4:39 ` Thanks M Hickford
2022-10-26 5:18 ` Thanks Jeff King
2022-10-26 9:36 ` Thanks Junio C Hamano
2022-11-12 2:21 ` [PATCH] docs: clarify that credential discards unrecognised attributes M Hickford
2022-11-12 16:47 ` Jeff King
2022-11-12 19:08 ` M Hickford
2022-11-14 22:40 ` Jeff King
2022-11-13 4:56 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1393.git.1666598268697.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=mirth.hickford@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.