From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH v2 0/2] ci: bump remaining outdated Actions versions
Date: Sun, 11 Feb 2024 12:11:27 +0000 [thread overview]
Message-ID: <pull.1660.v2.git.1707653489.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1660.git.1707652357696.gitgitgadget@gmail.com>
I noticed that Junio recently bumped a couple of these Actions versions, and
incidentally I also activated automatic Dependabot updates of those in
git-for-windows/git. Dependabot noticed a couple of yet-unaddressed updates,
which I accumulated into a single patch.
This patch is based on jc/github-actions-update.
Changes since v1 (sorry for the quick succession):
* The linux32 job cannot handle Node.js Actions, and therefore would fail
to run the latest actions/upload-artifact version. I only noticed this
after submitting v1 because CI does not fail (since this step is only in
use when something in Git's test suite breaks).
* To avoid making the same mistake even one more time, I added a commit
that puts big fat warnings next to the Actions that must not be updated
to newer (i.e. Node.js) versions.
Johannes Schindelin (2):
ci: bump remaining outdated Actions versions
ci(linux32): add a note about Actions that must not be updated
.github/workflows/coverity.yml | 4 ++--
.github/workflows/main.yml | 20 ++++++++++----------
2 files changed, 12 insertions(+), 12 deletions(-)
base-commit: dcce2bda214ac4c838f4b85f2c550816df3a6ac9
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1660%2Fdscho%2Fmoar-github-actions-updates-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1660/dscho/moar-github-actions-updates-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/1660
Range-diff vs v1:
1: 77c0810bf1a ! 1: 2b35b9878a7 ci: bump remaining outdated Actions versions
@@ .github/workflows/main.yml: jobs:
- name: Upload failed tests' directories
if: failure() && env.FAILED_TEST_ARTIFACTS != '' && matrix.vector.jobname != 'linux32'
- uses: actions/upload-artifact@v3
-+ uses: actions/upload-artifact@v4
- with:
- name: failed-tests-${{matrix.vector.jobname}}
- path: ${{env.FAILED_TEST_ARTIFACTS}}
- - name: Upload failed tests' directories
- if: failure() && env.FAILED_TEST_ARTIFACTS != '' && matrix.vector.jobname == 'linux32'
-- uses: actions/upload-artifact@v1
+ uses: actions/upload-artifact@v4
with:
name: failed-tests-${{matrix.vector.jobname}}
-: ----------- > 2: 9088cc60bda ci(linux32): add a note about Actions that must not be updated
--
gitgitgadget
next prev parent reply other threads:[~2024-02-11 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 11:52 [PATCH] ci: bump remaining outdated Actions versions Johannes Schindelin via GitGitGadget
2024-02-11 12:11 ` Johannes Schindelin via GitGitGadget [this message]
2024-02-11 12:11 ` [PATCH v2 1/2] " Johannes Schindelin via GitGitGadget
2024-02-11 12:11 ` [PATCH v2 2/2] ci(linux32): add a note about Actions that must not be updated Johannes Schindelin via GitGitGadget
2024-02-12 16:51 ` Junio C Hamano
2024-02-11 17:17 ` [PATCH] ci: bump remaining outdated Actions versions Junio C Hamano
2024-02-12 16:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1660.v2.git.1707653489.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.