All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] Fix a false negative in t3301-notes.sh
Date: Tue, 09 Apr 2019 03:41:22 -0700 (PDT)	[thread overview]
Message-ID: <pull.176.git.gitgitgadget@gmail.com> (raw)

It is always bad when test cases fail for the wrong reasons, but it is in
some ways more scary when they pass for the wrong reasons.

I stumbled over this issue while chasing down a Windows-specific issue that
caused two other test cases to fail, and should have caused this one to
fail, too, but didn't.

Johannes Schindelin (1):
  t3301: fix false negative

 t/t3301-notes.sh | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


base-commit: 8104ec994ea3849a968b4667d072fedd1e688642
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-176%2Fdscho%2Ffix-false-negative-in-t3301-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-176/dscho/fix-false-negative-in-t3301-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/176
-- 
gitgitgadget

             reply	other threads:[~2019-04-09 10:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-09 10:41 Johannes Schindelin via GitGitGadget [this message]
2019-04-09 10:41 ` [PATCH 1/1] t3301: fix false negative Johannes Schindelin via GitGitGadget
2019-04-09 11:33   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.176.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.