All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Dmitry Goncharov <dgoncharov@users.sf.net>,
	Elijah Newren <newren@gmail.com>
Subject: [PATCH 0/2] merge-ort: fix a crash in process_renames for a file transitively renamed to itself
Date: Thu, 06 Mar 2025 15:30:25 +0000	[thread overview]
Message-ID: <pull.1873.git.1741275027.gitgitgadget@gmail.com> (raw)

Maintainer note: this is not a recent regression; it need not be included in
v2.49.0.

This is a follow-up to Dmitry's report of a case where both merge-ort and
merge-recursive fail to properly handle a very specific type of conflict.
See
https://lore.kernel.org/git/20240921024533.15249-2-dgoncharov@users.sf.net/
for the earlier thread; the first patch is an adaptation of his
demonstrating the issue, and the second patch is my fix for it.

Dmitry Goncharov (1):
  t6423: add a testcase causing a failed assertion in process_renames

Elijah Newren (1):
  merge-ort: fix slightly overzealous assertion for rename-to-self

 merge-ort.c                         |  3 ++-
 t/t6423-merge-rename-directories.sh | 41 +++++++++++++++++++++++++++++
 2 files changed, 43 insertions(+), 1 deletion(-)


base-commit: f93ff170b93a1782659637824b25923245ac9dd1
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1873%2Fnewren%2Fendit-fix-funny-rename-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1873/newren/endit-fix-funny-rename-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1873
-- 
gitgitgadget

             reply	other threads:[~2025-03-06 15:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 15:30 Elijah Newren via GitGitGadget [this message]
2025-03-06 15:30 ` [PATCH 1/2] t6423: add a testcase causing a failed assertion in process_renames Dmitry Goncharov via GitGitGadget
2025-03-06 15:30 ` [PATCH 2/2] merge-ort: fix slightly overzealous assertion for rename-to-self Elijah Newren via GitGitGadget
2025-03-12 22:00   ` Taylor Blau
2025-03-12 22:36     ` Elijah Newren
2025-03-12 23:18       ` Junio C Hamano
2025-03-13  6:22         ` Elijah Newren
2025-03-13 16:55           ` Junio C Hamano
2025-03-13 17:15             ` Elijah Newren
2025-03-13 18:34               ` Junio C Hamano
2025-03-14  0:24                 ` Elijah Newren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1873.git.1741275027.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=dgoncharov@users.sf.net \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.