From: "Alex via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Alex <alexguo1023@gmail.com>, jinyaoguo <guo846@purdue.edu>
Subject: [PATCH] Add a check to prevent max_children from being 0.
Date: Fri, 23 May 2025 16:20:37 +0000 [thread overview]
Message-ID: <pull.1975.git.git.1748017238130.gitgitgadget@gmail.com> (raw)
From: jinyaoguo <guo846@purdue.edu>
In function fetch_multiple and fetch_submodules, `multiple` is
stored in `opt.process` and later used as a divisor in function
`pp_collect_finished`, creating a potential divide-by-zero if it
remains zero.
Signed-off-by: Alex Guo <alexguo1023@gmail.com>
---
Add a check to prevent max_children from being 0, which may cause
potential divide-by-zero.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1975%2Fmugitya03%2Fint2-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1975/mugitya03/int2-v1
Pull-Request: https://github.com/git/git/pull/1975
builtin/fetch.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index cda6eaf1fd6..b668187627a 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -2591,7 +2591,7 @@ int cmd_fetch(int argc,
die(_("--stdin can only be used when fetching "
"from one remote"));
- if (max_children < 0)
+ if (max_children <= 0)
max_children = config.parallel;
/* TODO should this also die if we have a previous partial-clone? */
@@ -2613,9 +2613,9 @@ int cmd_fetch(int argc,
struct strvec options = STRVEC_INIT;
int max_children = max_jobs;
- if (max_children < 0)
+ if (max_children <= 0)
max_children = config.submodule_fetch_jobs;
- if (max_children < 0)
+ if (max_children <= 0)
max_children = config.parallel;
add_options_to_argv(&options, &config);
base-commit: 8613c2bb6cd16ef530dc5dd74d3b818a1ccbf1c0
--
gitgitgadget
next reply other threads:[~2025-05-23 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 16:20 Alex via GitGitGadget [this message]
2025-05-23 19:30 ` [PATCH] Add a check to prevent max_children from being 0 Junio C Hamano
2025-05-25 15:19 ` Jinyao Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1975.git.git.1748017238130.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=alexguo1023@gmail.com \
--cc=git@vger.kernel.org \
--cc=guo846@purdue.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.