From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: johannes.schindelin@gmx.de, avarab@gmail.com,
Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/3] Close commit-graph before calling 'gc'
Date: Fri, 17 May 2019 11:41:46 -0700 (PDT) [thread overview]
Message-ID: <pull.208.git.gitgitgadget@gmail.com> (raw)
In Windows, the way we rename a lock file to replace the underlying file
does not work when a process holds a read handle. For this reason, we call
close_all_packs() everywhere before starting a git gc --auto subprocess. We
also call close_commit_graph() before renaming the commit-graph lock file.
But we don't close the commit-graph handles before running gc, which can
cause an issue when gc.writeCommitGraph is enabled.
This series adds close_commit_graph() to close_all_packs() and then renames
close_all_packs() to close_object_store(). This name is more descriptive of
its larger purpose.
This is based on ds/commit-graph-write-refactor to avoid conflicts.
Thanks, -Stolee
Derrick Stolee (3):
commit-graph: use raw_object_store when closing
packfile: close commit-graph in close_all_packs
packfile: close_all_packs to close_object_store
builtin/am.c | 2 +-
builtin/clone.c | 2 +-
builtin/fetch.c | 2 +-
builtin/gc.c | 4 ++--
builtin/merge.c | 2 +-
builtin/rebase.c | 2 +-
builtin/receive-pack.c | 2 +-
builtin/repack.c | 2 +-
commit-graph.c | 8 ++++----
commit-graph.h | 2 +-
object.c | 2 +-
packfile.c | 5 ++++-
packfile.h | 2 +-
upload-pack.c | 2 +-
14 files changed, 21 insertions(+), 18 deletions(-)
base-commit: 8520d7fc7c6edd4d71582c69a873436029b6cb1b
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-208%2Fderrickstolee%2Fclose-graph-everywhere-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-208/derrickstolee/close-graph-everywhere-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/208
--
gitgitgadget
next reply other threads:[~2019-05-17 18:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 18:41 Derrick Stolee via GitGitGadget [this message]
2019-05-17 18:41 ` [PATCH 1/3] commit-graph: use raw_object_store when closing Derrick Stolee via GitGitGadget
2019-05-17 18:41 ` [PATCH 2/3] packfile: close commit-graph in close_all_packs Derrick Stolee via GitGitGadget
2019-05-17 18:41 ` [PATCH 3/3] packfile: close_all_packs to close_object_store Derrick Stolee via GitGitGadget
2019-05-20 10:01 ` Johannes Schindelin
2019-05-20 11:55 ` Derrick Stolee
2019-05-28 16:29 ` Junio C Hamano
2019-05-19 2:04 ` [PATCH 0/3] Close commit-graph before calling 'gc' Junio C Hamano
2019-05-20 10:13 ` Johannes Schindelin
2019-05-20 11:05 ` Derrick Stolee
2019-05-20 9:40 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.208.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.