From: "aubrey via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: aubrey <aubyomori@gmail.com>, aubymori <aubyomori@gmail.com>
Subject: [PATCH] parse-options.c: display subcommands properly in check_typos
Date: Mon, 06 Apr 2026 18:38:26 +0000 [thread overview]
Message-ID: <pull.2084.git.1775500706920.gitgitgadget@gmail.com> (raw)
From: aubymori <aubyomori@gmail.com>
Before this, mistyping a subcommand with one dash (e.g. `git stash -list`)
would display a message telling the user to try it with two dashes.
Since subcommands are parsed with no dashes, this is incorrect and simply
results in the help message for that command being shown.
This commit changes check_typos to check the command type and display a
proper message for subcommands.
Signed-off-by: aubymori <aubyomori@gmail.com>
---
parse-options.c: display subcommands properly in check_typos
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2084%2Faubymori%2Fmaster-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2084/aubymori/master-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2084
parse-options.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/parse-options.c b/parse-options.c
index a676da86f5..2c4530bb8c 100644
--- a/parse-options.c
+++ b/parse-options.c
@@ -633,7 +633,10 @@ static void check_typos(const char *arg, const struct option *options)
if (!options->long_name)
continue;
if (starts_with(options->long_name, arg)) {
- error(_("did you mean `--%s` (with two dashes)?"), arg);
+ if (options->type == OPTION_SUBCOMMAND)
+ error(_("did you mean `%s` (with no dash)?"), arg);
+ else
+ error(_("did you mean `--%s` (with two dashes)?"), arg);
exit(129);
}
}
base-commit: 2855562ca6a9c6b0e7bc780b050c1e83c9fcfbd0
--
gitgitgadget
next reply other threads:[~2026-04-06 18:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 18:38 aubrey via GitGitGadget [this message]
2026-04-06 19:27 ` [PATCH] parse-options.c: display subcommands properly in check_typos Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.2084.git.1775500706920.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=aubyomori@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.