All of lore.kernel.org
 help / color / mirror / Atom feed
From: "AZero13 via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: AZero13 <gfunni234@gmail.com>, Greg Funni <gfunni234@gmail.com>
Subject: [PATCH v3] win32: pthread_cond_init should return a value
Date: Thu, 20 Nov 2025 21:43:36 +0000	[thread overview]
Message-ID: <pull.2103.v3.git.git.1763675016637.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2103.v2.git.git.1763480546981.gitgitgadget@gmail.com>

From: Greg Funni <gfunni234@gmail.com>

This value is not checked, but it must return to match POSIX

Signed-off-by: Greg Funni <gfunni234@gmail.com>
---
    win32: pthread_cond_init should return a value
    
    This value is not checked, but it must return to match POSIX

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2103%2FAZero13%2Fpthread-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2103/AZero13/pthread-v3
Pull-Request: https://github.com/git/git/pull/2103

Range-diff vs v2:

 1:  a2d9ec97f1 ! 1:  19ce5aca70 win32: pthread_cond_wait should return a value
     @@ Metadata
      Author: Greg Funni <gfunni234@gmail.com>
      
       ## Commit message ##
     -    win32: pthread_cond_wait should return a value
     +    win32: pthread_cond_init should return a value
      
          This value is not checked, but it must return to match POSIX
      


 compat/win32/pthread.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
index e2b5c4f64c..000604cdf6 100644
--- a/compat/win32/pthread.h
+++ b/compat/win32/pthread.h
@@ -34,7 +34,7 @@ typedef int pthread_mutexattr_t;
 
 #define pthread_cond_t CONDITION_VARIABLE
 
-#define pthread_cond_init(a,b) InitializeConditionVariable((a))
+#define pthread_cond_init(a,b) return_0((InitializeConditionVariable((a)), 0))
 #define pthread_cond_destroy(a) do {} while (0)
 #define pthread_cond_wait(a,b) return_0(SleepConditionVariableCS((a), (b), INFINITE))
 #define pthread_cond_signal WakeConditionVariable

base-commit: 5e6e4854e086ba0025bc7dc11e6b475c92a2f556
-- 
gitgitgadget

  parent reply	other threads:[~2025-11-20 21:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18  0:59 [PATCH] win32: pthread_cond_wait should return a value AZero13 via GitGitGadget
2025-11-18 15:42 ` [PATCH v2] " AZero13 via GitGitGadget
2025-11-18 18:17   ` Junio C Hamano
2025-11-20 21:43   ` AZero13 via GitGitGadget [this message]
2025-11-21  1:46     ` [PATCH v3] win32: pthread_cond_init " Junio C Hamano
2025-12-07  0:18       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.2103.v3.git.git.1763675016637.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=gfunni234@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.