All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] docs(git-pull.adoc): fix man page typo
@ 2025-11-28 13:16 Stefan Rieche via GitGitGadget
  2025-11-28 13:34 ` Kristoffer Haugsbakk
  2025-11-28 14:25 ` [PATCH v2] doc: git-pull: fix typo in command Stefan Rieche via GitGitGadget
  0 siblings, 2 replies; 5+ messages in thread
From: Stefan Rieche via GitGitGadget @ 2025-11-28 13:16 UTC (permalink / raw)
  To: git; +Cc: Stefan Rieche, snowdroppe

From: snowdroppe <stefanrieche@gmail.com>

Fix typo in man page from "git --rebase abort"
to "git rebase --abort"

Signed-off-by: Stefan Rieche <stefanrieche@gmail.com>
---
    docs(git-pull.adoc): fix man page typo

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2111%2Fsnowdroppe%2Fmaster-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2111/snowdroppe/master-v1
Pull-Request: https://github.com/git/git/pull/2111

 Documentation/git-pull.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-pull.adoc b/Documentation/git-pull.adoc
index cd3bbc90e3..d3006359ed 100644
--- a/Documentation/git-pull.adoc
+++ b/Documentation/git-pull.adoc
@@ -38,7 +38,7 @@ or `pull.ff` with your preferred behaviour.
 
 If there's a merge conflict during the merge or rebase that you don't
 want to handle, you can safely abort it with `git merge --abort` or `git
---rebase abort`.
+rebase --abort`.
 
 OPTIONS
 -------

base-commit: b31ab939fe8e3cbe8be48dddd1c6ac0265991f45
-- 
gitgitgadget

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs(git-pull.adoc): fix man page typo
  2025-11-28 13:16 [PATCH] docs(git-pull.adoc): fix man page typo Stefan Rieche via GitGitGadget
@ 2025-11-28 13:34 ` Kristoffer Haugsbakk
  2025-11-28 16:43   ` Junio C Hamano
  2025-11-28 14:25 ` [PATCH v2] doc: git-pull: fix typo in command Stefan Rieche via GitGitGadget
  1 sibling, 1 reply; 5+ messages in thread
From: Kristoffer Haugsbakk @ 2025-11-28 13:34 UTC (permalink / raw)
  To: Josh Soref, git; +Cc: Stefan Rieche

Nice fix.

> docs(git-pull.adoc): fix man page typo

Correct, you need an “area” in front of the message. But if you want
something like “docs” it would be more typical/conventional with
something like this:

    doc: pull:

or:

    doc: git-pull:

And then for the rest you don’t need “man page typo” since we know that
this is a doc already. And “man page” is too specific since you can make
HTML as well. Maybe:

    fix typo in command

On Fri, Nov 28, 2025, at 14:16, Stefan Rieche via GitGitGadget wrote:
> From: snowdroppe <stefanrieche@gmail.com>
>
> Fix typo in man page from "git --rebase abort"
> to "git rebase --abort"
>
> Signed-off-by: Stefan Rieche <stefanrieche@gmail.com>

The `From:` (author) and signoff line should match. See `real-name` in
`Documentation/SubmittingPatches`. Either a pseudonym or real/preferred
name. But it looks like you want to use your real name.

I see on the PR that you have used `snowdroppe <stefanrieche@gmail.com>`
as the author on the commit. You can change your config for the project
to use the same name and email as the signoff line. Then

    git commit --amend --reset-author

And force push to the branch on the remote.

> ---
>     docs(git-pull.adoc): fix man page typo
>
> Published-As:
> https://github.com/gitgitgadget/git/releases/tag/pr-git-2111%2Fsnowdroppe%2Fmaster-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git
> pr-git-2111/snowdroppe/master-v1
> Pull-Request: https://github.com/git/git/pull/2111
>
>  Documentation/git-pull.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/git-pull.adoc b/Documentation/git-pull.adoc
> index cd3bbc90e3..d3006359ed 100644
> --- a/Documentation/git-pull.adoc
> +++ b/Documentation/git-pull.adoc
> @@ -38,7 +38,7 @@ or `pull.ff` with your preferred behaviour.
>
>  If there's a merge conflict during the merge or rebase that you don't
>  want to handle, you can safely abort it with `git merge --abort` or `git
> ---rebase abort`.
> +rebase --abort`.
>
>  OPTIONS
>  -------
>
> base-commit: b31ab939fe8e3cbe8be48dddd1c6ac0265991f45
> --
> gitgitgadget

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] doc: git-pull: fix typo in command
  2025-11-28 13:16 [PATCH] docs(git-pull.adoc): fix man page typo Stefan Rieche via GitGitGadget
  2025-11-28 13:34 ` Kristoffer Haugsbakk
@ 2025-11-28 14:25 ` Stefan Rieche via GitGitGadget
  2025-12-02 23:49   ` [PATCH v3] doc: fix typo in git-pull.adoc Stefan Rieche via GitGitGadget
  1 sibling, 1 reply; 5+ messages in thread
From: Stefan Rieche via GitGitGadget @ 2025-11-28 14:25 UTC (permalink / raw)
  To: git; +Cc: Stefan Rieche, snowdroppe

From: snowdroppe <stefanrieche@gmail.com>

Fix typo in git-pull doc from "git --rebase abort"
to "git rebase --abort"

Signed-off-by: snowdroppe <stefanrieche@gmail.com>
---
    doc: git-pull: fix typo in command
    
    Changes since v1:
    
     * Updated commit message as suggested by Kristoffer Haugsbakk cc:
       "Kristoffer Haugsbakk" kristofferhaugsbakk@fastmail.com

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2111%2Fsnowdroppe%2Fmaster-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2111/snowdroppe/master-v2
Pull-Request: https://github.com/git/git/pull/2111

Range-diff vs v1:

 1:  5a37a725df ! 1:  a4a2c58461 docs(git-pull.adoc): fix man page typo
     @@ Metadata
      Author: snowdroppe <stefanrieche@gmail.com>
      
       ## Commit message ##
     -    docs(git-pull.adoc): fix man page typo
     +    doc: git-pull: fix typo in command
      
     -    Fix typo in man page from "git --rebase abort"
     +    Fix typo in git-pull doc from "git --rebase abort"
          to "git rebase --abort"
      
     -    Signed-off-by: Stefan Rieche <stefanrieche@gmail.com>
     +    Signed-off-by: snowdroppe <stefanrieche@gmail.com>
      
       ## Documentation/git-pull.adoc ##
      @@ Documentation/git-pull.adoc: or `pull.ff` with your preferred behaviour.


 Documentation/git-pull.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-pull.adoc b/Documentation/git-pull.adoc
index cd3bbc90e3..d3006359ed 100644
--- a/Documentation/git-pull.adoc
+++ b/Documentation/git-pull.adoc
@@ -38,7 +38,7 @@ or `pull.ff` with your preferred behaviour.
 
 If there's a merge conflict during the merge or rebase that you don't
 want to handle, you can safely abort it with `git merge --abort` or `git
---rebase abort`.
+rebase --abort`.
 
 OPTIONS
 -------

base-commit: b31ab939fe8e3cbe8be48dddd1c6ac0265991f45
-- 
gitgitgadget

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] docs(git-pull.adoc): fix man page typo
  2025-11-28 13:34 ` Kristoffer Haugsbakk
@ 2025-11-28 16:43   ` Junio C Hamano
  0 siblings, 0 replies; 5+ messages in thread
From: Junio C Hamano @ 2025-11-28 16:43 UTC (permalink / raw)
  To: Kristoffer Haugsbakk; +Cc: Josh Soref, git, Stefan Rieche

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

> Nice fix.
>
>> docs(git-pull.adoc): fix man page typo
>
> Correct, you need an “area” in front of the message. But if you want
> something like “docs” it would be more typical/conventional with
> something like this:
>
>     doc: pull:
>
> or:
>
>     doc: git-pull:

or

	doc: fix typo in git-pull.adoc

>> Fix typo in man page from "git --rebase abort"
>> to "git rebase --abort"
>>
>> Signed-off-by: Stefan Rieche <stefanrieche@gmail.com>
>
> The `From:` (author) and signoff line should match. See `real-name` in
> `Documentation/SubmittingPatches`. Either a pseudonym or real/preferred
> name. But it looks like you want to use your real name.
>
> I see on the PR that you have used `snowdroppe <stefanrieche@gmail.com>`
> as the author on the commit. You can change your config for the project
> to use the same name and email as the signoff line. Then
>
>     git commit --amend --reset-author
>
> And force push to the branch on the remote.

Great.  Which would mean that the in-body From: line early in the
message will also say Stefan Rieche, not snowdroppe.

Thanks for a review.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v3] doc: fix typo in git-pull.adoc
  2025-11-28 14:25 ` [PATCH v2] doc: git-pull: fix typo in command Stefan Rieche via GitGitGadget
@ 2025-12-02 23:49   ` Stefan Rieche via GitGitGadget
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Rieche via GitGitGadget @ 2025-12-02 23:49 UTC (permalink / raw)
  To: git; +Cc: Kristoffer Haugsbakk, Junio C Hamano, Stefan Rieche, snowdroppe

From: snowdroppe <stefanrieche@gmail.com>

Fix typo in git-pull.doc from "git --rebase abort"
to "git rebase --abort"

Signed-off-by: snowdroppe <stefanrieche@gmail.com>
---
    doc: fix typo in git-pull.adoc
    
    Changes since v1:
    
     * Updated commit message as suggested by Kristoffer Haugsbakk

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2111%2Fsnowdroppe%2Fmaster-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2111/snowdroppe/master-v3
Pull-Request: https://github.com/git/git/pull/2111

Range-diff vs v2:

 1:  a4a2c58461 ! 1:  7ea5aabac5 doc: git-pull: fix typo in command
     @@ Metadata
      Author: snowdroppe <stefanrieche@gmail.com>
      
       ## Commit message ##
     -    doc: git-pull: fix typo in command
     +    doc: fix typo in git-pull.adoc
      
     -    Fix typo in git-pull doc from "git --rebase abort"
     +    Fix typo in git-pull.doc from "git --rebase abort"
          to "git rebase --abort"
      
          Signed-off-by: snowdroppe <stefanrieche@gmail.com>


 Documentation/git-pull.adoc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/git-pull.adoc b/Documentation/git-pull.adoc
index cd3bbc90e3..d3006359ed 100644
--- a/Documentation/git-pull.adoc
+++ b/Documentation/git-pull.adoc
@@ -38,7 +38,7 @@ or `pull.ff` with your preferred behaviour.
 
 If there's a merge conflict during the merge or rebase that you don't
 want to handle, you can safely abort it with `git merge --abort` or `git
---rebase abort`.
+rebase --abort`.
 
 OPTIONS
 -------

base-commit: b31ab939fe8e3cbe8be48dddd1c6ac0265991f45
-- 
gitgitgadget

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-12-02 23:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-28 13:16 [PATCH] docs(git-pull.adoc): fix man page typo Stefan Rieche via GitGitGadget
2025-11-28 13:34 ` Kristoffer Haugsbakk
2025-11-28 16:43   ` Junio C Hamano
2025-11-28 14:25 ` [PATCH v2] doc: git-pull: fix typo in command Stefan Rieche via GitGitGadget
2025-12-02 23:49   ` [PATCH v3] doc: fix typo in git-pull.adoc Stefan Rieche via GitGitGadget

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.