From: "AZero13 via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: AZero13 <gfunni234@gmail.com>, Greg Funni <gfunni234@gmail.com>
Subject: [PATCH v2] repository: remove duplicate free of cache->squash_msg
Date: Thu, 18 Dec 2025 15:49:12 +0000 [thread overview]
Message-ID: <pull.2132.v2.git.git.1766072952115.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2132.git.git.1766071566022.gitgitgadget@gmail.com>
From: Greg Funni <gfunni234@gmail.com>
Thankfully, it is set to NULL, so no security consequences.
However, this is still a mistake that must be rectified.
Signed-off-by: Greg Funni <gfunni234@gmail.com>
---
repository: remove duplicate free of cache->squash_msg
Thankfully, it is set to NULL, so no security consequences.
However, this is still a mistake that must be rectified.
Signed-off-by: Greg Funni gfunni234@gmail.com
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2132%2FAZero13%2Ftwice-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2132/AZero13/twice-v2
Pull-Request: https://github.com/git/git/pull/2132
Range-diff vs v1:
1: 35d0606190 ! 1: ac2abd592d repository: cache->squash_msg is freed twice
@@ Metadata
Author: Greg Funni <gfunni234@gmail.com>
## Commit message ##
- repository: cache->squash_msg is freed twice
+ repository: remove duplicate free of cache->squash_msg
Thankfully, it is set to NULL, so no security consequences.
However, this is still a mistake that must be rectified.
repository.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/repository.c b/repository.c
index 863f24411b..c7e75215ac 100644
--- a/repository.c
+++ b/repository.c
@@ -349,7 +349,6 @@ out:
static void repo_clear_path_cache(struct repo_path_cache *cache)
{
- FREE_AND_NULL(cache->squash_msg);
FREE_AND_NULL(cache->squash_msg);
FREE_AND_NULL(cache->merge_msg);
FREE_AND_NULL(cache->merge_rr);
base-commit: c4a0c8845e2426375ad257b6c221a3a7d92ecfda
--
gitgitgadget
next prev parent reply other threads:[~2025-12-18 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 15:26 [PATCH] repository: cache->squash_msg is freed twice AZero13 via GitGitGadget
2025-12-18 15:49 ` AZero13 via GitGitGadget [this message]
2025-12-18 18:18 ` Eric Sunshine
2025-12-19 3:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.2132.v2.git.git.1766072952115.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=gfunni234@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.