From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Patrick Steinhardt <ps@pks.im>,
Karthik Nayak <karthik.188@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH v2 0/4] gitlab-ci: fix the cargo invocation in the Windows job
Date: Thu, 24 Sep 2026 20:01:49 +0000 [thread overview]
Message-ID: <pull.2233.v2.git.1790280113.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2233.git.1789819933.gitgitgadget@gmail.com>
In https://lore.kernel.org/git/xmqq8q4zosri.fsf@gitster.g/, Junio mentioned
that the GitLab CI seems broken since I enabled Rust in the Windows-based CI
jobs. This patch series should fix it (lightly tested, but I don't have a
whole lot of build minutes on GitLab).
Changes since v1:
* Reworded the commit messages to clarify previously confusing statements.
Johannes Schindelin (4):
ci(gitlab,windows): provision GNU Rust for SDK-based MinGW builds
ci(gitlab,windows): preserve exclusions during dependency setup
ci(gitlab,windows): fix Rust setup for GitLab's MinGW build
ci(gitlab,windows): provide GNU Rust's host-linker support
.gitlab-ci.yml | 5 ++++-
ci/install-dependencies.ps1 | 22 ++++++++++++++++------
2 files changed, 20 insertions(+), 7 deletions(-)
base-commit: d38352cd43ab9745686d697872408bc3249a153f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2233%2Fdscho%2Ffix-cargo-in-windows-gitlab-ci-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2233/dscho/fix-cargo-in-windows-gitlab-ci-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/2233
Range-diff vs v1:
1: 6a389b2bad ! 1: cdf2eff480 ci(gitlab,windows): provision GNU Rust for SDK-based MinGW builds
@@ Metadata
## Commit message ##
ci(gitlab,windows): provision GNU Rust for SDK-based MinGW builds
- The minimal Git for Windows SDK already supplies Git and GCC. The
- MinGW Makefile build needs the GNU Rust toolchain, not another Git
- installation or Meson.
+ The minimal Git for Windows SDK already supplies Git and GCC. The MinGW
+ Makefile build needs the Rust toolchain that targets GCC (as opposed to
+ the more common MSVC one), not another Git installation or Meson.
- Let the dependency installer serve this configuration while keeping
- the existing package set for MSVC builds.
+ Prepare the `install-dependencies.ps1` script to be able to install the
+ GCC-targeting Rust toolchain.
Assisted-by: GPT-6
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
2: 8855c25128 = 2: 19a4d93181 ci(gitlab,windows): preserve exclusions during dependency setup
3: 57a83d15fd = 3: 6703fa0349 ci(gitlab,windows): fix Rust setup for GitLab's MinGW build
4: 1ed79f00cf ! 4: 5310afcdf9 ci(gitlab,windows): provide GNU Rust's host-linker support
@@ Commit message
https://gitlab.com/dscho/git1/-/jobs/16593470275
Although gitcore is a static library, Cargo first links `build.rs`
- as a host executable. We omitted the GNU MSI's `Gcc` feature, which
+ as a host executable. We omitted the Rust MSI's `Gcc` feature, which
supplies the required linker and platform libraries:
https://github.com/rust-lang/rust/blob/1.96.0/src/etc/installer/msi/rust.wxs
--
gitgitgadget
next prev parent reply other threads:[~2026-09-24 20:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 12:12 [PATCH 0/4] gitlab-ci: fix the cargo invocation in the Windows job Johannes Schindelin via GitGitGadget
2026-09-19 12:12 ` [PATCH 1/4] ci(gitlab,windows): provision GNU Rust for SDK-based MinGW builds Johannes Schindelin via GitGitGadget
2026-09-24 11:21 ` Patrick Steinhardt
2026-09-24 19:26 ` Johannes Schindelin
2026-09-19 12:12 ` [PATCH 2/4] ci(gitlab,windows): preserve exclusions during dependency setup Johannes Schindelin via GitGitGadget
2026-09-24 11:21 ` Patrick Steinhardt
2026-09-19 12:12 ` [PATCH 3/4] ci(gitlab,windows): fix Rust setup for GitLab's MinGW build Johannes Schindelin via GitGitGadget
2026-09-24 11:22 ` Patrick Steinhardt
2026-09-24 19:55 ` Johannes Schindelin
2026-09-28 6:50 ` Patrick Steinhardt
2026-09-28 14:33 ` Junio C Hamano
2026-09-19 12:12 ` [PATCH 4/4] ci(gitlab,windows): provide GNU Rust's host-linker support Johannes Schindelin via GitGitGadget
2026-09-24 11:22 ` Patrick Steinhardt
2026-09-24 19:57 ` Johannes Schindelin
2026-09-19 13:37 ` [PATCH 0/4] gitlab-ci: fix the cargo invocation in the Windows job Karthik Nayak
2026-09-20 15:27 ` Johannes Schindelin
2026-09-21 14:03 ` Karthik Nayak
2026-09-22 11:50 ` Johannes Schindelin
2026-09-23 12:43 ` Karthik Nayak
2026-09-24 20:01 ` Johannes Schindelin via GitGitGadget [this message]
2026-09-24 20:01 ` [PATCH v2 1/4] ci(gitlab,windows): provision GNU Rust for SDK-based MinGW builds Johannes Schindelin via GitGitGadget
2026-09-24 20:01 ` [PATCH v2 2/4] ci(gitlab,windows): preserve exclusions during dependency setup Johannes Schindelin via GitGitGadget
2026-09-24 20:01 ` [PATCH v2 3/4] ci(gitlab,windows): fix Rust setup for GitLab's MinGW build Johannes Schindelin via GitGitGadget
2026-09-24 20:01 ` [PATCH v2 4/4] ci(gitlab,windows): provide GNU Rust's host-linker support Johannes Schindelin via GitGitGadget
2026-09-28 6:50 ` [PATCH v2 0/4] gitlab-ci: fix the cargo invocation in the Windows job Patrick Steinhardt
2026-09-28 13:41 ` Johannes Schindelin
2026-09-28 14:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.2233.v2.git.1790280113.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=karthik.188@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.