From: "Jayesh Daga via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: K Jayatheerth <jayatheerthkulkarni2005@gmail.com>,
Jayesh Daga <jayeshdaga99@gmail.com>
Subject: [PATCH 0/2] t/pack-refs-tests: fix helper usage
Date: Sun, 22 Mar 2026 12:46:24 +0000 [thread overview]
Message-ID: <pull.2247.git.git.1774183586.gitgitgadget@gmail.com> (raw)
High-level (Intent & Context)
=============================
The test script t/pack-refs-tests.sh has two issues that prevent it from
running correctly.
It uses: ! test -f .git/refs/heads/f
This is inconsistent with the Git test framework, where helper functions
such as test_path_is_missing should be used instead of raw test checks.
Low-level (Implementation & Justification)
==========================================
Without sourcing test-lib.sh, the test framework is not initialized, leading
to errors such as: test_expect_success: not found
* Replaced raw file check with the appropriate helper:
- ! test -f .git/refs/heads/f
+ test_path_is_missing .git/refs/heads/f
Summary
* Replace test -f with test_path_is_missing
jayesh0104 (2):
t/pack-refs-tests: drop '-f' from test_path_is_missing
t/pack-refs-tests: drop '-f' from test_path_is_missing
t/pack-refs-tests.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
base-commit: 6e8d538aab8fe4dd07ba9fb87b5c7edcfa5706ad
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2247%2Fjayesh0104%2Ffix-pack-refs-test-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2247/jayesh0104/fix-pack-refs-test-v1
Pull-Request: https://github.com/git/git/pull/2247
--
gitgitgadget
next reply other threads:[~2026-03-22 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 12:46 Jayesh Daga via GitGitGadget [this message]
2026-03-22 12:46 ` [PATCH 1/2] t/pack-refs-tests: drop '-f' from test_path_is_missing jayesh0104 via GitGitGadget
2026-03-22 12:46 ` [PATCH 2/2] " jayesh0104 via GitGitGadget
2026-03-22 13:29 ` K Jayatheerth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.2247.git.git.1774183586.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=jayatheerthkulkarni2005@gmail.com \
--cc=jayeshdaga99@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.