All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Srujith A Poojary via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Usman Akinyemi <usmanakinyemi202@gmail.com>,
	Patrick Steinhardt <ps@pks.im>,
	Srujith A Poojary <poojarysrujith@gmail.com>,
	Srujith Poojary <poojarysrujith@gmail.com>
Subject: [PATCH v4] [Outreachy PATCH] t0001: avoid pipes in test scripts
Date: Thu, 29 Oct 2026 14:34:23 +0000	[thread overview]
Message-ID: <pull.2260.v4.git.1793284463139.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2260.git.1792299301663.gitgitgadget@gmail.com>

From: Srujith Poojary <poojarysrujith@gmail.com>

Avoid piping output from git version directly into sed to ensure
that any command failure is properly caught by test scripts.

Signed-off-by: Srujith Poojary <poojarysrujith@gmail.com>
---
    [Outreachy PATCH] t0001: avoid pipes in test scripts

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2260%2Fpoojarysrujith%2Fmicroproject-init-pipe-v4
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2260/poojarysrujith/microproject-init-pipe-v4
Pull-Request: https://github.com/gitgitgadget/git/pull/2260

Range-diff vs v3:

 1:  a70ccdf49e ! 1:  4373eef413 [Outreachy PATCH] t0001: avoid pipes in test scripts
     @@ Commit message
          [Outreachy PATCH] t0001: avoid pipes in test scripts
      
          Avoid piping output from git version directly into sed to ensure
     -
          that any command failure is properly caught by test scripts.
      
          Signed-off-by: Srujith Poojary <poojarysrujith@gmail.com>


 t/t0001-init.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/t/t0001-init.sh b/t/t0001-init.sh
index f1d227f271..c8c74f681b 100755
--- a/t/t0001-init.sh
+++ b/t/t0001-init.sh
@@ -678,7 +678,8 @@ test_expect_success 'default ref format' '
 		sane_unset GIT_DEFAULT_REF_STORAGE_FORMAT &&
 		git init refformat
 	) &&
-	git version --build-options | sed -ne "s/^default-ref-storage-format: //p" >expect &&
+	git version --build-options >build-options &&
+	sed -ne "s/^default-ref-storage-format: //p" build-options >expect &&
 	git -C refformat rev-parse --show-ref-storage-format >actual &&
 	test_cmp expect actual
 '

base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd
-- 
gitgitgadget

      parent reply	other threads:[~2026-10-29 14:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-18  4:55 [PATCH] [Outreachy PATCH] t0001: avoid pipes in test scripts Srujith A Poojary via GitGitGadget
2026-10-21 22:03 ` Usman Akinyemi
2026-10-22 10:50 ` [PATCH v2] " Srujith A Poojary via GitGitGadget
2026-10-22 10:53   ` Srujith Poojary
2026-10-22 17:24   ` Junio C Hamano
2026-10-23  4:34     ` Srujith Poojary
2026-10-23  5:13 ` [PATCH v3] " Srujith A Poojary via GitGitGadget
2026-10-23 16:23   ` Srujith Poojary
2026-10-29 12:12   ` Patrick Steinhardt
2026-10-29 14:36     ` Srujith Poojary
2026-10-29 14:34 ` Srujith A Poojary via GitGitGadget [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.2260.v4.git.1793284463139.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=poojarysrujith@gmail.com \
    --cc=ps@pks.im \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.