From: "Joy via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Patrick Steinhardt>" <ps@pks.im>,
"Kristoffer Haugsbakk>" <kristofferhaugsbakk@fastmail.com>,
"Christian Couder>" <christian.couder@gmail.com>,
"Usman Akinyemi>" <usmanakinyemi202@gmail.com>,
Joie Joie <soniqjjj@gmail.com>, Patrick Steinhardt <ps@pks.im>,
Tanga Joris <tangajoris@gmail.com>, Joy <soniqjjj@gmail.com>,
Joy Gundu <soniqjjj@gmail.com>
Subject: [PATCH] repo: zero-initialize configuration values
Date: Fri, 06 Nov 2026 11:59:28 +0000 [thread overview]
Message-ID: <pull.2298.git.1793966368860.gitgitgadget@gmail.com> (raw)
From: Joy Gundu <soniqjjj@gmail.com>
Use memset() to initialize repository configuration values to
zero, removing the need for explicit zero and NULL assignments.
Keep non-zero defaults initialized separately.
Signed-off-by: Joy Gundu <soniqjjj@gmail.com>
---
[Outreachy] repo: zero-initialize configuration values
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2298%2FJoiejoie1%2Frepo-zero-initialize-config-values-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2298/Joiejoie1/repo-zero-initialize-config-values-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2298
environment.c | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/environment.c b/environment.c
index c83cf44839..afe35cff99 100644
--- a/environment.c
+++ b/environment.c
@@ -752,34 +752,22 @@ int git_default_config(const char *var, const char *value,
void repo_config_values_init(struct repo_config_values *cfg)
{
+ memset(cfg, 0, sizeof(*cfg));
+
/* section "core" config values */
- cfg->attributes_file = NULL;
- cfg->excludes_file = NULL;
- cfg->editor_program = NULL;
- cfg->pager_program = NULL;
- cfg->askpass_program = NULL;
- cfg->apply_default_whitespace = NULL;
- cfg->apply_default_ignorewhitespace = NULL;
cfg->push_default = PUSH_DEFAULT_UNSPECIFIED;
cfg->autorebase = AUTOREBASE_NEVER;
cfg->object_creation_mode = OBJECT_CREATION_MODE;
- cfg->apply_sparse_checkout = 0;
cfg->trust_ctime = 1;
cfg->check_stat = 1;
cfg->zlib_compression_level = Z_BEST_SPEED;
cfg->pack_compression_level = Z_DEFAULT_COMPRESSION;
cfg->precomposed_unicode = -1; /* see probe_utf8_pathname_composition() */
- cfg->core_sparse_checkout_cone = 0;
cfg->warn_on_object_refname_ambiguity = 1;
cfg->protect_hfs = PROTECT_HFS_DEFAULT;
cfg->protect_ntfs = PROTECT_NTFS_DEFAULT;
- cfg->ignore_case = 0;
cfg->trust_executable_bit = 1;
cfg->has_symlinks = platform_has_symlinks();
- cfg->use_nanosec = 0;
-
- /* section "sparse" config values */
- cfg->sparse_expect_files_outside_of_patterns = 0;
/* section "branch" config values */
cfg->branch_track = BRANCH_TRACK_REMOTE;
base-commit: 3de8ebe6c8cfcd312cdbfa675635810140f84c8a
--
gitgitgadget
next reply other threads:[~2026-11-06 11:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 11:59 Joy via GitGitGadget [this message]
2026-11-06 14:16 ` [PATCH] repo: zero-initialize configuration values Patrick Steinhardt
2026-11-06 16:19 ` Joie Joie
2026-11-06 19:36 ` Junio C Hamano
2026-11-09 14:26 ` Joie Joie
2026-11-09 19:05 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.2298.git.1793966368860.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=ps@pks.im \
--cc=soniqjjj@gmail.com \
--cc=tangajoris@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.