All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ammaar Bakshi via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Ammaar Bakshi <the.ammaar.ic@gmail.com>,
	AMMAAR-IC <the.ammaar.ic@gmail.com>
Subject: [PATCH] difftool: translate "combined diff formats" error message
Date: Sat, 17 Oct 2026 06:40:39 +0000	[thread overview]
Message-ID: <pull.2447.git.git.1792219239440.gitgitgadget@gmail.com> (raw)

From: AMMAAR-IC <the.ammaar.ic@gmail.com>

The error shown when "git difftool --dir-diff" is given a combined
diff format ('-c' or '--cc') is wrapped in N_(), which only marks the
string for extraction by xgettext and does nothing at runtime. As the
string is passed straight to die(), users always see it in English,
even though it already has translations in the po files.

Use _() instead, and adjust the indentation of the continuation lines
to match.

Signed-off-by: AMMAAR-IC <the.ammaar.ic@gmail.com>
---
    difftool: translate "combined diff formats" error message

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2447%2FAmmaarBakshi%2Fdifftool-i18n-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2447/AmmaarBakshi/difftool-i18n-v1
Pull-Request: https://github.com/git/git/pull/2447

 builtin/difftool.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/builtin/difftool.c b/builtin/difftool.c
index bc7b2ea443..13b3d3ce47 100644
--- a/builtin/difftool.c
+++ b/builtin/difftool.c
@@ -450,9 +450,9 @@ static int run_dir_diff(struct repository *repo,
 		const char *src_path, *dst_path;
 
 		if (starts_with(info.buf, "::"))
-			die(N_("combined diff formats ('-c' and '--cc') are "
-			       "not supported in\n"
-			       "directory diff mode ('-d' and '--dir-diff')."));
+			die(_("combined diff formats ('-c' and '--cc') are "
+			      "not supported in\n"
+			      "directory diff mode ('-d' and '--dir-diff')."));
 
 		if (parse_index_info(repo, info.buf, &lmode, &rmode, &loid, &roid, &status))
 			break;

base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd
-- 
gitgitgadget

                 reply	other threads:[~2026-10-17  6:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.2447.git.git.1792219239440.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=the.ammaar.ic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.