All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ophir Bleicher via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Ophir Bleicher <ophirble@gmail.com>, Ophir Bleicher <ophirble@gmail.com>
Subject: [PATCH v3] setup: fix incorrect word in code comment
Date: Sat, 21 Nov 2026 17:35:58 +0000	[thread overview]
Message-ID: <pull.2500.v3.git.git.1795282558789.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2500.git.git.1795279741855.gitgitgadget@gmail.com>

From: Ophir Bleicher <ophirble@gmail.com>

Fix an incorrect word problem in line 271 of setup.c:

will only complain about an inexisting file.

Change it to 'non-existent'.

Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
---
    setup: fix incorrect word in code comment
    
    Changes since v1:
    
     * Update commit message from grammar to incorrect word
     * Change word to non-existent instead of non-existing Changes since v2:
     * Really change word to non-existent instead of non-existing

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2500%2FOphirBleicher%2Fsetup-code-typo-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2500/OphirBleicher/setup-code-typo-v3
Pull-Request: https://github.com/git/git/pull/2500

Range-diff vs v2:

 1:  3b7539bd5f ! 1:  2158470090 setup: fix incorrect word in code comment
     @@ setup.c: static int looks_like_pathspec(const char *arg)
        * If set to 1, the diagnosis will try to diagnose "name" as an
        * invalid object name (e.g. HEAD:foo). If set to 0, the diagnosis
      - * will only complain about an inexisting file.
     -+ * will only complain about a non-existing file.
     ++ * will only complain about a non-existent file.
        *
        * This function is typically called to check that a "file or rev"
        * argument is unambiguous. In this case, the caller will want


 setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/setup.c b/setup.c
index cedc031c54..3aaa1b65b2 100644
--- a/setup.c
+++ b/setup.c
@@ -268,7 +268,7 @@ static int looks_like_pathspec(const char *arg)
  * diagnosis when dying upon finding that "name" is not a pathname.
  * If set to 1, the diagnosis will try to diagnose "name" as an
  * invalid object name (e.g. HEAD:foo). If set to 0, the diagnosis
- * will only complain about an inexisting file.
+ * will only complain about a non-existent file.
  *
  * This function is typically called to check that a "file or rev"
  * argument is unambiguous. In this case, the caller will want

base-commit: f7de81456940dd6f3274e461149bba12965de609
-- 
gitgitgadget

      parent reply	other threads:[~2026-11-21 17:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 16:49 [PATCH] setup: fix grammar in code comment Ophir Bleicher via GitGitGadget
2026-11-21 17:27 ` D. Ben Knoble
2026-11-21 17:29   ` Ophir Bleicher
2026-11-21 17:33 ` [PATCH v2] setup: fix incorrect word " Ophir Bleicher via GitGitGadget
2026-11-21 17:35 ` Ophir Bleicher via GitGitGadget [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.2500.v3.git.git.1795282558789.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ophirble@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.