All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nika Layzell via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Nika Layzell <nika@thelayzells.com>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] add--interactive: skip index refresh in reset patch mode
Date: Sat, 23 Nov 2019 19:56:39 +0000	[thread overview]
Message-ID: <pull.475.git.1574539001.gitgitgadget@gmail.com> (raw)

The refresh command is called from git-add--interactive to ensure that git's
view of the worktree is up-to-date. This is necessary for most commands
which use git-add--interactive, as they are interacting with the worktree,
however it's not necessary for git-reset, which exclusively operates on the
index. This patch skips the refresh call when performing a git-reset -p,
which can improve performance on large repositories which have out-of-date,
or no, caches of the current worktree state.

I chose to use the existing FILTER property of the flavour to make this
decision. A separate REFRESH property could be added instead.

Nika Layzell (1):
  add--interactive: skip index refresh in reset patch mode

 git-add--interactive.perl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


base-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-475%2Fmystor%2Findex-only-refresh-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-475/mystor/index-only-refresh-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/475
-- 
gitgitgadget

             reply	other threads:[~2019-11-23 19:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-23 19:56 Nika Layzell via GitGitGadget [this message]
2019-11-23 19:56 ` [PATCH 1/1] add--interactive: skip index refresh in reset patch mode Nika Layzell via GitGitGadget
2019-11-24  6:01 ` [PATCH 0/1] " Junio C Hamano
2019-11-25 14:24   ` Johannes Schindelin
2019-11-25 14:45     ` Johannes Schindelin
2019-11-26  1:13       ` Junio C Hamano
2021-01-07 14:18         ` Cc'ing the Git maintainer on GitGitGadget contributions, was " Johannes Schindelin
2021-01-07 14:57           ` Ævar Arnfjörð Bjarmason
2021-01-07 16:20             ` Johannes Schindelin
2021-01-07 21:25               ` Junio C Hamano
2021-01-08 14:56                 ` Johannes Schindelin
2021-01-08 19:48                   ` Junio C Hamano
2021-01-10 12:02                     ` Johannes Schindelin
2021-01-08 20:08                   ` Taylor Blau
2021-01-10 12:21                     ` Johannes Schindelin
2021-01-10 20:18                       ` Junio C Hamano
2021-01-11 19:18                         ` Taylor Blau
2021-01-12 23:22                           ` Junio C Hamano
2021-01-14  6:32                         ` 胡哲宁
2019-11-26  1:12     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.475.git.1574539001.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nika@thelayzells.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.