All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
	Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/2] Refuse to write to reserved filenames on Windows
Date: Sat, 21 Dec 2019 22:04:59 +0000	[thread overview]
Message-ID: <pull.496.git.1576965901.gitgitgadget@gmail.com> (raw)

On Windows, for historical reasons, file names such as aux.c, nul.txt are
not allowed. For aux.c, attempts to write such a file will result in an
obscure error, for nul.txt the call will succeed but no such file will
appear, ever, instead the effect will be equivalent to writing to /dev/null 
on Linux/Unix.

Let's help users by refusing to create such files altogether, with an
informative error message.

Johannes Schindelin (2):
  mingw: short-circuit the conversion of `/dev/null` to UTF-16
  mingw: refuse paths containing reserved names

 compat/mingw.c        | 122 +++++++++++++++++++++++++++++++++++-------
 compat/mingw.h        |  11 +++-
 t/t0060-path-utils.sh |  13 ++++-
 3 files changed, 122 insertions(+), 24 deletions(-)


base-commit: 53a06cf39b756eddfe4a2a34da93e3d04eb7b728
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-496%2Fdscho%2Fmingw-reserved-filenames-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-496/dscho/mingw-reserved-filenames-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/496
-- 
gitgitgadget

             reply	other threads:[~2019-12-21 22:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-21 22:04 Johannes Schindelin via GitGitGadget [this message]
2019-12-21 22:05 ` [PATCH 1/2] mingw: short-circuit the conversion of `/dev/null` to UTF-16 Johannes Schindelin via GitGitGadget
2019-12-21 22:05 ` [PATCH 2/2] mingw: refuse paths containing reserved names Johannes Schindelin via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.496.git.1576965901.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.