All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Derrick Stolee <dstolee@microsoft.com>,
	Junio C Hamano <gitster@pobox.com>
Subject: [PATCH 0/1] sparse-checkout: use extern for global variables
Date: Tue, 31 Dec 2019 13:17:47 +0000	[thread overview]
Message-ID: <pull.506.git.1577798268.gitgitgadget@gmail.com> (raw)

I noticed this issue when resolving conflicts with our VFS for Git-enabled
branch in microsoft/git.

When I moved the global for core.sparseCheckout along with creating the
global for core.sparseCheckoutCone, I dropped the "extern" by habit. (We are
dropping these from function declarations, usually.) However, this means
something different for variables, and could lead to bugs. I haven't found
any, but it's better to be safe, right?

Thanks, -Stolee

Derrick Stolee (1):
  sparse-checkout: use extern for global variables

 cache.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 99c33bed562b41de6ce9bd3fd561303d39645048
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-506%2Fderrickstolee%2Fsparse-extern-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-506/derrickstolee/sparse-extern-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/506
-- 
gitgitgadget

             reply	other threads:[~2019-12-31 13:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-31 13:17 Derrick Stolee via GitGitGadget [this message]
2019-12-31 13:17 ` [PATCH 1/1] sparse-checkout: use extern for global variables Derrick Stolee via GitGitGadget
2020-01-02 18:17   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.506.git.1577798268.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.