From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH v2 0/3] Prepare git credential to read input with DOS line endings
Date: Mon, 28 Sep 2020 11:40:21 +0000 [thread overview]
Message-ID: <pull.710.v2.git.git.1601293224.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.710.git.git.1581688196706.gitgitgadget@gmail.com>
This contribution came in via Git for Windows
[https://github.com/git-for-windows/git/pull/2516].
Sadly, I did not find the time to go through all the changes of 8f309aeb
("strbuf: introduce strbuf_getline_{lf,nul}()", 2016-01-13) (as Junio asked
[https://public-inbox.org/git/xmqqmu9lnjdh.fsf@gitster-ct.c.googlers.com]).
Rather than delaying this patch indefinitely, I admit defeat on that angle.
Changes since v1:
* Added a commit to adjust credential-daemon and credential-store in the
same manner.
* Adjusted the documentation accordingly.
Nikita Leonov (3):
credential.c: fix credential reading with regards to CR/LF
credentials: make line reading Windows compatible
docs: make notes regarding credential line reading
Documentation/git-credential.txt | 4 +++-
Documentation/gitcredentials.txt | 2 ++
builtin/credential-cache--daemon.c | 4 ++--
builtin/credential-store.c | 2 +-
credential.c | 2 +-
t/t0302-credential-store.sh | 16 ++++++----------
6 files changed, 15 insertions(+), 15 deletions(-)
base-commit: 9bc233ae1cf19a49e51842c7959d80a675dbd1c0
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-710%2Fdscho%2Fcrlf-aware-git-credential-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-710/dscho/crlf-aware-git-credential-v2
Pull-Request: https://github.com/git/git/pull/710
Range-diff vs v1:
1: 2a9cc710bb = 1: 27f6400a21 credential.c: fix credential reading with regards to CR/LF
-: ---------- > 2: f69076036f credentials: make line reading Windows compatible
-: ---------- > 3: 61baea1061 docs: make notes regarding credential line reading
--
gitgitgadget
next prev parent reply other threads:[~2020-09-28 11:40 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 13:49 [PATCH] credential.c: fix credential reading with regards to CR/LF Johannes Schindelin via GitGitGadget
2020-02-14 17:55 ` Junio C Hamano
2020-02-14 18:32 ` Jeff King
2020-09-28 11:40 ` Johannes Schindelin via GitGitGadget [this message]
2020-09-28 11:40 ` [PATCH v2 1/3] " Nikita Leonov via GitGitGadget
2020-09-29 0:42 ` Jeff King
2020-10-02 11:37 ` Johannes Schindelin
2020-10-02 12:01 ` Jeff King
2020-10-02 12:27 ` Johannes Schindelin
2020-10-02 16:32 ` Junio C Hamano
2020-10-03 13:28 ` Johannes Schindelin
2020-09-28 11:40 ` [PATCH v2 2/3] credentials: make line reading Windows compatible Nikita Leonov via GitGitGadget
2020-09-28 20:58 ` Junio C Hamano
2020-09-29 0:35 ` Jeff King
2020-09-30 22:33 ` Junio C Hamano
2020-10-02 7:53 ` Johannes Schindelin
2020-09-28 23:26 ` Carlo Arenas
2020-09-28 23:41 ` Junio C Hamano
2020-09-29 0:30 ` Jeff King
2020-09-29 0:41 ` Junio C Hamano
2020-09-29 0:44 ` Jeff King
2020-09-29 0:54 ` Junio C Hamano
2020-09-29 3:00 ` Jeff King
2020-09-30 22:25 ` Junio C Hamano
2020-09-30 22:39 ` Jeff King
2020-09-30 22:56 ` Junio C Hamano
2020-10-01 13:54 ` Jeff King
2020-10-01 15:42 ` Junio C Hamano
2020-10-02 8:07 ` Johannes Schindelin
2020-09-28 11:40 ` [PATCH v2 3/3] docs: make notes regarding credential line reading Nikita Leonov via GitGitGadget
2020-09-28 20:31 ` [PATCH v2 0/3] Prepare git credential to read input with DOS line endings Junio C Hamano
2020-10-03 13:29 ` [PATCH v3] credential: treat CR/LF as line endings in the credential protocol Johannes Schindelin via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.710.v2.git.git.1601293224.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.