From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, stolee@gmail.com,
Derrick Stolee <derrickstolee@github.com>,
Derrick Stolee <dstolee@microsoft.com>
Subject: [PATCH] remote: initialize values that might not be set
Date: Mon, 07 Jun 2021 12:39:29 +0000 [thread overview]
Message-ID: <pull.974.git.1623069570553.gitgitgadget@gmail.com> (raw)
From: Derrick Stolee <dstolee@microsoft.com>
I noticed during an unrelated test with Valgrind that these variables
might be left un-set by stat_tracking_info() in some cases. Initialize
them so that a later branch upon their value is consistent.
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
---
remote: initialize values that might not be set
A very minor fixup.
Thanks, -Stolee
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-974%2Fderrickstolee%2Fremote-uninitialized-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-974/derrickstolee/remote-uninitialized-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/974
remote.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/remote.c b/remote.c
index c3f85c17ca7c..a116392fb057 100644
--- a/remote.c
+++ b/remote.c
@@ -2101,7 +2101,7 @@ int stat_tracking_info(struct branch *branch, int *num_ours, int *num_theirs,
int format_tracking_info(struct branch *branch, struct strbuf *sb,
enum ahead_behind_flags abf)
{
- int ours, theirs, sti;
+ int ours = 0, theirs = 0, sti = 0;
const char *full_base;
char *base;
int upstream_is_gone = 0;
base-commit: 71ca53e8125e36efbda17293c50027d31681a41f
--
gitgitgadget
next reply other threads:[~2021-06-07 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 12:39 Derrick Stolee via GitGitGadget [this message]
2021-06-07 21:59 ` [PATCH] remote: initialize values that might not be set Johannes Schindelin
2021-06-07 23:21 ` Junio C Hamano
2021-06-10 9:24 ` Johannes Schindelin
2021-06-11 1:41 ` Junio C Hamano
2021-06-11 17:56 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.974.git.1623069570553.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=derrickstolee@github.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.