From: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/2] Add more eol=lf to .gitattributes
Date: Wed, 12 Dec 2018 10:14:51 -0800 (PST) [thread overview]
Message-ID: <pull.98.v2.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.98.git.gitgitgadget@gmail.com>
I noticed that our CI builds (see [1] for an example) were returning success
much faster than they did before Git v2.20.0. Turns out that there was a
test script failure involving the new test hash logic.
error: bug in the test script: bad hash algorithm
make[1]: *** [Makefile:56: t0000-basic.sh] Error 1
make[1]: *** Waiting for unfinished jobs....
This failure was due to an LF -> CRLF conversion in some data files in
t/oid-info/. Don't munge these files, and the tests can continue.
UPDATED IN V2: Unfortunately, I didn't check the full test suite after
getting beyond this point, and found another LF -> CRLF conversion problem
in t4256-am-format-flowed.sh due to example patches in t/t4256/1/. Add these
in a second commit. Thanks, dscho, for helping with the correct placement.
Thanks, -Stolee
[1] https://gvfs.visualstudio.com/ci/_build/results?buildId=4815
Derrick Stolee (1):
.gitattributes: ensure t/oid-info/* has eol=lf
Johannes Schindelin (1):
t4256: mark support files as LF-only
.gitattributes | 1 +
t/.gitattributes | 1 +
2 files changed, 2 insertions(+)
base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-98%2Fderrickstolee%2Ftest-oid-fix-windows-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-98/derrickstolee/test-oid-fix-windows-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/98
Range-diff vs v1:
1: 4a22502a31 = 1: 4a22502a31 .gitattributes: ensure t/oid-info/* has eol=lf
-: ---------- > 2: 4275b8a581 t4256: mark support files as LF-only
--
gitgitgadget
next prev parent reply other threads:[~2018-12-12 18:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 20:35 [PATCH 0/1] .gitattributes: ensure t/oid-info/* has eol=lf Derrick Stolee via GitGitGadget
2018-12-11 20:35 ` [PATCH 1/1] " Derrick Stolee via GitGitGadget
2018-12-12 13:39 ` SZEDER Gábor
2018-12-13 13:01 ` Johannes Schindelin
2018-12-13 13:22 ` SZEDER Gábor
2018-12-13 13:44 ` Johannes Schindelin
2018-12-12 8:38 ` [PATCH 0/1] " Junio C Hamano
2018-12-12 18:14 ` Derrick Stolee via GitGitGadget [this message]
2018-12-12 18:14 ` [PATCH v2 1/2] " Derrick Stolee via GitGitGadget
2018-12-13 2:38 ` Junio C Hamano
2018-12-13 16:22 ` Derrick Stolee
2018-12-14 2:23 ` Junio C Hamano
2018-12-14 0:51 ` brian m. carlson
2018-12-14 11:10 ` Johannes Schindelin
2018-12-12 18:14 ` [PATCH v2 2/2] t4256: mark support files as LF-only Johannes Schindelin via GitGitGadget
2018-12-13 2:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.98.v2.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.