All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Chris. Webster" <chris@webstech.net>,
	Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: [PATCH 0/2] check-whitespace: two fixes
Date: Wed, 14 Jul 2021 22:09:35 +0000	[thread overview]
Message-ID: <pull.995.git.1626300577.gitgitgadget@gmail.com> (raw)

I recently ran into a situation where a merge commit (which admittedly are
undesirable in git/git and gitgitgadget/git Pull Requests, but are sometimes
totally appropriate in the context of other forks such as
git-for-windows/git) misled the logic in the check-whitespace workflow to
look at upstream commits (and missing some patches that it should have
looked at).

At the same time, I also realized that the feature where this workflow adds
a PR comment in an attempt to be more helpful requires a read/write token
(which weakens the overall security, I'd much rather stay with the read-only
token configured e.g. in gitgitgadget/git and in git-for-windows/git).

This patch series addresses both issues.

Johannes Schindelin (2):
  ci(check-whitespace): stop requiring a read/write token
  ci(check-whitespace): restrict to the intended commits

 .github/workflows/check-whitespace.yml | 26 ++------------------------
 1 file changed, 2 insertions(+), 24 deletions(-)


base-commit: ebf3c04b262aa27fbb97f8a0156c2347fecafafb
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-995%2Fdscho%2Ffix-check-whitespace-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-995/dscho/fix-check-whitespace-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/995
-- 
gitgitgadget

             reply	other threads:[~2021-07-14 22:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 22:09 Johannes Schindelin via GitGitGadget [this message]
2021-07-14 22:09 ` [PATCH 1/2] ci(check-whitespace): stop requiring a read/write token Johannes Schindelin via GitGitGadget
2021-07-14 22:20   ` Junio C Hamano
2021-07-14 22:09 ` [PATCH 2/2] ci(check-whitespace): restrict to the intended commits Johannes Schindelin via GitGitGadget
2021-07-14 22:25   ` Junio C Hamano
2021-07-14 22:29     ` Taylor Blau
2021-07-15 13:00       ` Johannes Schindelin
2021-07-15 12:59     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.995.git.1626300577.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=chris@webstech.net \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.