From: Alexander Clouter <alex@digriz.org.uk>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH 3/3] MIPS: AR7 make ar7_register_devices much more durable
Date: Mon, 1 Feb 2010 20:15:22 +0000 [thread overview]
Message-ID: <qbpj37-cao.ln1@chipmunk.wormnet.eu> (raw)
In-Reply-To: 20100201190159.GC9806@linux-mips.org
Ralf Baechle <ralf@linux-mips.org> wrote:
>
> On Sun, Jan 31, 2010 at 07:39:57PM +0000, Alexander Clouter wrote:
>
>> MIPS: AR7 make ar7_register_devices much more durable
>
> patches/0070-03.patch:85: space before tab in indent.
> }
> patches/0070-03.patch:192: space before tab in indent.
> iounmap(bootcr);
> patches/0070-03.patch:208: space before tab in indent.
> res = platform_device_register(&ar7_wdt);
> error: patch failed: arch/mips/ar7/platform.c:529
> error: arch/mips/ar7/platform.c: patch does not apply
>
> Grrr :-)
>
My grovelling apologies, I do normally worship at the altar of
checkpatch.pl however my faith was recently shattered by the acceptance
for lines longer than 80 chars...
> I've fixed that up, also the pr_xxx changes suggested by Wu. Queued
> for 2.6.34.
>
I have some other code for you to rewrite if you are willing?
All this manual fixing up does makeme ponder if you are trying to avoid
doing something else you should be doing though :)
Sorry again and also my thanks
--
Alexander Clouter
.sigmonster says: YOW!! The land of the rising SONY!!
prev parent reply other threads:[~2010-02-01 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 19:39 [PATCH 3/3] MIPS: AR7 make ar7_register_devices much more durable Alexander Clouter
2010-02-01 6:32 ` Wu Zhangjin
2010-02-01 19:02 ` Ralf Baechle
2010-02-01 20:15 ` Alexander Clouter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qbpj37-cao.ln1@chipmunk.wormnet.eu \
--to=alex@digriz.org.uk \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.