All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roesch <shr@devkernel.io>
To: Matthew Wilcox <willy@infradead.org>
Cc: kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com,
	mhocko@suse.com, david@redhat.com,
	linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org,
	akpm@linux-foundation.org, hannes@cmpxchg.org,
	Bagas Sanjaya <bagasdotme@gmail.com>
Subject: Re: [PATCH v5 1/3] mm: add new api to enable ksm per process
Date: Tue, 11 Apr 2023 16:03:57 -0700	[thread overview]
Message-ID: <qvqw4jpm58cv.fsf@dev0134.prn3.facebook.com> (raw)
In-Reply-To: <ZDXgmx0xD8ch/Iu5@casper.infradead.org>


Matthew Wilcox <willy@infradead.org> writes:

> On Thu, Apr 06, 2023 at 09:53:37AM -0700, Stefan Roesch wrote:
>> +	case PR_SET_MEMORY_MERGE:
>> +		if (mmap_write_lock_killable(me->mm))
>> +			return -EINTR;
>> +
>> +		if (arg2) {
>> +			int err = ksm_add_mm(me->mm);
>> +			if (err)
>> +				return err;
>
> You'll return to userspace with the mutex held, no?
>

Thanks for catching this, I'll fix it in the next version.

  reply	other threads:[~2023-04-11 23:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06 16:53 [PATCH v5 0/3] mm: process/cgroup ksm support Stefan Roesch
2023-04-06 16:53 ` [PATCH v5 1/3] mm: add new api to enable ksm per process Stefan Roesch
2023-04-06 23:29   ` Andrew Morton
2023-04-07  4:09     ` Stefan Roesch
2023-04-11 22:35   ` Matthew Wilcox
2023-04-11 23:03     ` Stefan Roesch [this message]
2023-04-06 16:53 ` [PATCH v5 2/3] mm: add new KSM process and sysfs knobs Stefan Roesch
2023-04-11  9:10   ` David Hildenbrand
2023-04-11 22:29     ` Stefan Roesch
2023-04-06 16:53 ` [PATCH v5 3/3] selftests/mm: add new selftests for KSM Stefan Roesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=qvqw4jpm58cv.fsf@dev0134.prn3.facebook.com \
    --to=shr@devkernel.io \
    --cc=akpm@linux-foundation.org \
    --cc=bagasdotme@gmail.com \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=riel@surriel.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.