From: Stefan Roesch <shr@devkernel.io>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Facebook Kernel Team <kernel-team@fb.com>,
Jens Axboe <axboe@kernel.dk>,
Olivier Langlois <olivier@trillion01.com>,
netdev Mailing List <netdev@vger.kernel.org>,
io-uring Mailing List <io-uring@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [RFC PATCH v4 1/4] liburing: add api to set napi busy poll settings
Date: Mon, 21 Nov 2022 10:58:45 -0800 [thread overview]
Message-ID: <qvqwsfic3zik.fsf@dev0134.prn3.facebook.com> (raw)
In-Reply-To: <c5ac425d-48e2-0a6d-3f56-c6154d3ac81f@gnuweeb.org>
Ammar Faizi <ammarfaizi2@gnuweeb.org> writes:
> On 11/19/22 11:11 AM, Stefan Roesch wrote:
>> +
>> +int io_uring_register_napi(struct io_uring *ring, struct io_uring_napi *napi)
>> +{
>> + return __sys_io_uring_register(ring->ring_fd,
>> + IORING_REGISTER_NAPI, napi, 0);
>> +}
>> +
>> +int io_uring_unregister_napi(struct io_uring *ring, struct io_uring_napi *napi)
>> +{
>> + return __sys_io_uring_register(ring->ring_fd,
>> + IORING_REGISTER_NAPI, napi, 0);
>> +}
>
> The latter should be IORING_UNREGISTER_NAPI instead of IORING_REGISTER_NAPI?
> Or did I miss something?
Thats correct.
next prev parent reply other threads:[~2022-11-21 18:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 4:11 [RFC PATCH v4 0/4] liburing: add api for napi busy poll Stefan Roesch
2022-11-19 4:11 ` [RFC PATCH v4 1/4] liburing: add api to set napi busy poll settings Stefan Roesch
2022-11-19 11:09 ` Ammar Faizi
2022-11-21 18:58 ` Stefan Roesch [this message]
2022-11-19 4:11 ` [RFC PATCH v4 2/4] liburing: add documentation for new napi busy polling Stefan Roesch
2022-11-19 22:46 ` Ammar Faizi
2022-11-21 19:04 ` Stefan Roesch
2022-11-19 4:11 ` [RFC PATCH v4 3/4] liburing: add example programs for napi busy poll Stefan Roesch
2022-11-19 12:47 ` Ammar Faizi
2022-11-21 19:02 ` Stefan Roesch
2022-11-19 4:11 ` [RFC PATCH v4 4/4] liburing: update changelog with new feature Stefan Roesch
2022-11-19 22:59 ` [RFC PATCH v4 0/4] liburing: add api for napi busy poll Ammar Faizi
2022-11-20 19:34 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2022-11-19 4:11 Stefan Roesch
2022-11-19 4:11 ` [RFC PATCH v4 1/4] liburing: add api to set napi busy poll settings Stefan Roesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qvqwsfic3zik.fsf@dev0134.prn3.facebook.com \
--to=shr@devkernel.io \
--cc=ammarfaizi2@gnuweeb.org \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olivier@trillion01.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.