From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 784D2C63777 for ; Thu, 3 Dec 2020 03:55:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15A0421D7A for ; Thu, 3 Dec 2020 03:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729567AbgLCDzo (ORCPT ); Wed, 2 Dec 2020 22:55:44 -0500 Received: from static.214.254.202.116.clients.your-server.de ([116.202.254.214]:34598 "EHLO ciao.gmane.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727838AbgLCDzn (ORCPT ); Wed, 2 Dec 2020 22:55:43 -0500 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1kkfht-0003ym-Vk for netdev@vger.kernel.org; Thu, 03 Dec 2020 04:55:01 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: netdev@vger.kernel.org From: Grant Edwards Subject: Re: net: macb: fail when there's no PHY Date: Thu, 3 Dec 2020 03:54:57 -0000 (UTC) Message-ID: References: <20170921195905.GA29873@grante> <66c0a032-4d20-69f1-deb4-6c65af6ec740@gmail.com> <6a9c1d4a-ed73-3074-f9fa-158c697c7bfe@gmail.com> <20201202183531.GJ2324545@lunn.ch> <20201202211134.GM2324545@lunn.ch> <57728908-1ae3-cbe9-8721-81f06ab688b8@gmail.com> User-Agent: slrn/1.0.3 (Linux) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020-12-03, Florian Fainelli wrote: > You would have to have a local hack that intercepts the macb_ioctl() > and instead of calling phylink_mii_ioctl() it would have to > implement a custom ioctl() that does what > drivers/net/phy/phy.c::phy_mii_ioctl does except the mdiobus should > be pointed to the MACB MDIO bus instance and not be derived from the > phy_device instance (because that one points to the fixed PHY). So I can avoid my local hack to macb_main.c by doing a doing a local hack to macb_main.c? -- Grant