From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B6FAC433C1 for ; Mon, 22 Mar 2021 11:27:46 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 137506198E for ; Mon, 22 Mar 2021 11:27:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 137506198E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 963771657; Mon, 22 Mar 2021 12:26:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 963771657 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1616412463; bh=u5I/QUVEWOeZJU7vtJNdFk7AL2KeLbzyWvH/t/RtWnQ=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FvyXOX67x0nqJfg50l/g2FDN98yZpkZDXAsg/WVdji3JVNDvjKCtRQkmFShVBviWo p1A8dJ4SdjpLbUGaMnAW9zeuuelbiY14x4uuOnaAw2C/Xec80eYbfkqahaHm/LgX7V ISMhO4cBzKJOXqFkzKDtQaMJq2MwDmBSAlO6t8wk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 27A35F801D5; Mon, 22 Mar 2021 12:26:53 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 872ADF801EC; Mon, 22 Mar 2021 12:26:51 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 57712F80156 for ; Mon, 22 Mar 2021 12:26:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 57712F80156 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 20AF5ADD7; Mon, 22 Mar 2021 11:26:45 +0000 (UTC) Date: Mon, 22 Mar 2021 12:26:45 +0100 Message-ID: From: Takashi Iwai To: Arnd Bergmann Subject: Re: [PATCH] ALSA: core: avoid -Wempty-body warnings In-Reply-To: <20210322103128.547199-1-arnd@kernel.org> References: <20210322103128.547199-1-arnd@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Takashi Iwai , Arnd Bergmann X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 22 Mar 2021 11:31:10 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > Building with 'make W=1' shows some warnings about empty function-style > macros: > > sound/core/pcm_memory.c: In function 'preallocate_pages': > sound/core/pcm_memory.c:236:49: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 236 | preallocate_info_init(substream); > > sound/core/seq_device.c: In function 'snd_seq_device_dev_register': > sound/core/seq_device.c:163:41: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 163 | queue_autoload_drivers(); > > Change them to empty inline functions, which are more robust here. > > Signed-off-by: Arnd Bergmann Thanks, applied. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03F14C433DB for ; Mon, 22 Mar 2021 11:27:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C56736191F for ; Mon, 22 Mar 2021 11:27:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229990AbhCVL07 (ORCPT ); Mon, 22 Mar 2021 07:26:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:37326 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230015AbhCVL0q (ORCPT ); Mon, 22 Mar 2021 07:26:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 20AF5ADD7; Mon, 22 Mar 2021 11:26:45 +0000 (UTC) Date: Mon, 22 Mar 2021 12:26:45 +0100 Message-ID: From: Takashi Iwai To: Arnd Bergmann Cc: Jaroslav Kysela , Takashi Iwai , Arnd Bergmann , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: core: avoid -Wempty-body warnings In-Reply-To: <20210322103128.547199-1-arnd@kernel.org> References: <20210322103128.547199-1-arnd@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Mar 2021 11:31:10 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > Building with 'make W=1' shows some warnings about empty function-style > macros: > > sound/core/pcm_memory.c: In function 'preallocate_pages': > sound/core/pcm_memory.c:236:49: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 236 | preallocate_info_init(substream); > > sound/core/seq_device.c: In function 'snd_seq_device_dev_register': > sound/core/seq_device.c:163:41: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] > 163 | queue_autoload_drivers(); > > Change them to empty inline functions, which are more robust here. > > Signed-off-by: Arnd Bergmann Thanks, applied. Takashi