From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70FB6C433E0 for ; Thu, 14 Jan 2021 12:22:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF26823A53 for ; Thu, 14 Jan 2021 12:22:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF26823A53 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5BCE91697; Thu, 14 Jan 2021 13:21:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5BCE91697 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1610626937; bh=7tMMJNbD/lv8Rcn4YaixvUfXPNojHgRlbd2mbjRCok0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bIsHG06Y3tFce1zs9PMTJiRLWkewB5AUxfJ9n657CQ8WjRd0cmC7iLc0JKvivDnTg Vnyk6Rxcur8jdWEF4+GaKUARYve6X4JZd17JIoUKRvZHjpuTetW1Yb7c9h5xQmxRoY LUVp9KlfWAvbEzkxH+08kehTY/ticp7+qeSV0wcU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E2EB8F80249; Thu, 14 Jan 2021 13:21:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 78439F8025E; Thu, 14 Jan 2021 13:21:25 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0202BF80113 for ; Thu, 14 Jan 2021 13:21:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0202BF80113 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DCDDAB775; Thu, 14 Jan 2021 12:21:16 +0000 (UTC) Date: Thu, 14 Jan 2021 13:21:16 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH v2] ASoC: SOF: Intel: initial support to AlderLake-P In-Reply-To: <20210114115558.52699-1-kai.vehmanen@linux.intel.com> References: <20210114115558.52699-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Guennadi Liakhovetski , alsa-devel@alsa-project.org, daniel.baluta@nxp.com, ranjani.sridharan@linux.intel.com, lgirdwood@gmail.com, broonie@kernel.org, pierre-louis.bossart@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 14 Jan 2021 12:55:58 +0100, Kai Vehmanen wrote: > > Add PCI id for the AlderLake-P. > > Signed-off-by: Kai Vehmanen > Reviewed-by: Ranjani Sridharan > Reviewed-by: Pierre-Louis Bossart > Reviewed-by: Guennadi Liakhovetski > --- > sound/soc/sof/sof-pci-dev.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > V2 changes: > - fix compile error if CONFIG_SND_SOC_SOF_TIGERLAKE=n and > CONFIG_SND_SOC_SOF_ALDERLAKE is enabled > > diff --git a/sound/soc/sof/sof-pci-dev.c b/sound/soc/sof/sof-pci-dev.c > index 63b989e3ec40..ebd58d49d570 100644 > --- a/sound/soc/sof/sof-pci-dev.c > +++ b/sound/soc/sof/sof-pci-dev.c > @@ -213,7 +213,7 @@ static const struct sof_dev_desc icl_desc = { > }; > #endif > > -#if IS_ENABLED(CONFIG_SND_SOC_SOF_TIGERLAKE) > +#if IS_ENABLED(CONFIG_SND_SOC_SOF_TIGERLAKE) || IS_ENABLED(CONFIG_SND_SOC_SOF_ALDERLAKE) > static const struct sof_dev_desc tgl_desc = { > .machines = snd_soc_acpi_intel_tgl_machines, > .alt_machines = snd_soc_acpi_intel_tgl_sdw_machines, I guess snd_soc_acpi_intel_tgl_* would be missing even by this patch alone if TIGERLAKE=n and ALDERLAKE=y. IMO, the easiest fix would be to select CONFIG_SND_SOC_SOF_TIGERLAKE from CONFIG_SND_SOC_SOF_ALDERLAKE forcibly in Kconfig instead. Then no tweak of ifdef is needed. thanks, Takashi