Re: [PATCH 1/7] Unify M-Audio Fast Track Ultra and Ebox-44 mixer quirks.

From: Takashi Iwai <tiwai@suse.de>
To: Felix Homann <linuxaudio@showlabor.de>
Cc: alsa-devel@alsa-project.org, patch@alsa-project.org, mark@pogo.org.uk
Subject: Re: [PATCH 1/7] Unify M-Audio Fast Track Ultra and Ebox-44 mixer quirks.
Date: Mon, 23 Apr 2012 18:01:54 +0200	[thread overview]
Message-ID: <s5h1une5te5.wl%tiwai@suse.de> (raw)
In-Reply-To: <CAFz=ag5PzRJ1eaV819kBtmnfGpM_b+xKBwHaNidd7wxBtK4vMQ@mail.gmail.com>

At Mon, 23 Apr 2012 18:00:03 +0200,
Felix Homann wrote:
> 
> Hi,
> 
> 2012/4/23 Takashi Iwai <tiwai@suse.de>:
> > At Mon, 23 Apr 2012 16:37:31 +0200,
> > Felix Homann wrote:
> >>
> >> +     /* set TLV */
> >> +     if (!tlv_callback) {
> >
> > I guess you want without !, no?
> 
> you're absolutely right.
> 
> 
> >> +     snd_create_std_mono_ctl(mixer, 10, 2, 0x2, USB_MIXER_S16,
> >> +                             "Input B Capture Volume", NULL);
> >
> > It would be safer to check the error of each call, but then it'd be
> > better to make a table and loop over it.  You can create a new patch
> > for that.
> 
> Please, tell Mark Hills. It's his patch you applied a couple of days
> ago. I just renamed the functions and added the 'NULL' at the end of
> the calls.

Well, if you are already working on it, you are the best position to
add such simple fixes ;)  Otherwise we'll get merge conflicts.
As mentioned, just create a new patch to add the error checks.

thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel