Re: [PATCH] alsa-tools

[Takashi Iwai <tiwai@suse.de>]

At Mon, 16 May 2005 16:41:24 +0200,
Mikael Magnusson wrote:
> 
> ld10k1_configure.patch
> ld10k1_makefile.patch
> Removes ALSA_CFLAGS and ALSA_LIBS in configure.in, they are added to
> CFLAGS and LDADD in src/Makefile.am already. Adds "-Wall" to CFLAGS only
> if CFLAGS is undefined.
> 
> qlo10k1_configure.patch
> qlo10k1_makefile.patch
> Adds LD10K1_CFLAGS and LD10K1_LDFLAGS in src/Makefile.am, and moves
> QT_CXXFLAGS to the makefile.
> 
> qlo10k1_acinclude.patch
> Fixes pattern in gw_CHECK_QT not to match files that the linker won't
> use, for example libqt.so.3 . Needed if both libqt and libqt-mt shared
> libraries are installed, but only the libqt-mt development library.

Thanks.  I think we can get rid of -Wall.
It's not mandatory at all.  Let's simply remove CFLAGS=XXX lines.

Could you regenerate patches with that change?


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7412&alloc_id=16344&op=click