From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918A6C433E1 for ; Wed, 19 Aug 2020 17:19:39 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E93F8207FF for ; Wed, 19 Aug 2020 17:19:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="kjrvSLp0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E93F8207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7246C1673; Wed, 19 Aug 2020 19:18:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7246C1673 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1597857577; bh=YpAqtif9b9psey6iEfLuKmV51aLYuxHOaVaSjTe+0Dg=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=kjrvSLp07MmmLetZunccWbf22I+wiPRgdWWaIScO9an8bHhafKCGh/MYI4iVPtzGJ teKZ5drhdhK9ULJdQa8H7AKTpJ794tnJMsB0LwirAJMagdUF5t8wFE5WQHggVRyr2Z WRl4els0dlmUraADqYmk3PDDV0cNEtOTNo2gOZmw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EEB36F80216; Wed, 19 Aug 2020 19:18:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1D4B5F80218; Wed, 19 Aug 2020 19:18:45 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 70CF5F80114 for ; Wed, 19 Aug 2020 19:18:33 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 70CF5F80114 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BE2ABAD8D; Wed, 19 Aug 2020 17:18:57 +0000 (UTC) Date: Wed, 19 Aug 2020 19:18:30 +0200 Message-ID: From: Takashi Iwai To: penghao Subject: Re: [PATCH] ALSA: usb-audio: Add prevent wakeup from s3 state trig by Lenovo ThinkCentre TI024Gen3 USB-audio In-Reply-To: <20200819115757.23168-1-penghao@uniontech.com> References: <20200819115757.23168-1-penghao@uniontech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, crwulff@gmail.com, gustavoars@kernel.org, Hui Wang , alexander@tsoy.me, Kai-Heng Feng , Mark Pearson , dan.carpenter@oracle.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" [ Adding a few more relevant people to Cc. ] On Wed, 19 Aug 2020 13:57:57 +0200, penghao wrote: > > TI024Gen3 USB-audio is controlled by TI024Gen3,when TI024Gens > enter sleep mode, USB-audio will disconnect from USB bus port, > wakup form s3 state > > Signed-off-by: penghao > --- > sound/usb/card.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/usb/card.c b/sound/usb/card.c > index 696e788c5d31..6bdbb34009b3 100644 > --- a/sound/usb/card.c > +++ b/sound/usb/card.c > @@ -658,6 +658,12 @@ static int usb_audio_probe(struct usb_interface *intf, > } > > dev_set_drvdata(&dev->dev, chip); > + /* > + *ALSA: usb-audio: Add prevent wakeup from s3 state trig by Lenovo > + *ThinkCentre TI024Gen3 usb-audio > + */ > + if ((usb_id->idVendor == 0x17ef) && (usb_id->idProduct == 0xa012)) > + device_set_wakeup_enable(＆dev->dev, 0); Here it's no proper ASCII letter, and this must be broken. Please check the actual patch before submitting. In anyway, before going further, I'd like to hear from other people whether this is really mandatory and appropriate. And whether it's specific to that device, too (not other Lenovo devices?) thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DEF3C433DF for ; Wed, 19 Aug 2020 17:18:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 567E0207FF for ; Wed, 19 Aug 2020 17:18:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726745AbgHSRSd (ORCPT ); Wed, 19 Aug 2020 13:18:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:40168 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbgHSRSc (ORCPT ); Wed, 19 Aug 2020 13:18:32 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BE2ABAD8D; Wed, 19 Aug 2020 17:18:57 +0000 (UTC) Date: Wed, 19 Aug 2020 19:18:30 +0200 Message-ID: From: Takashi Iwai To: penghao Cc: Mark Pearson , Hui Wang , Kai-Heng Feng , perex@perex.cz, alexander@tsoy.me, dan.carpenter@oracle.com, crwulff@gmail.com, gustavoars@kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: Add prevent wakeup from s3 state trig by Lenovo ThinkCentre TI024Gen3 USB-audio In-Reply-To: <20200819115757.23168-1-penghao@uniontech.com> References: <20200819115757.23168-1-penghao@uniontech.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Adding a few more relevant people to Cc. ] On Wed, 19 Aug 2020 13:57:57 +0200, penghao wrote: > > TI024Gen3 USB-audio is controlled by TI024Gen3,when TI024Gens > enter sleep mode, USB-audio will disconnect from USB bus port, > wakup form s3 state > > Signed-off-by: penghao > --- > sound/usb/card.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/usb/card.c b/sound/usb/card.c > index 696e788c5d31..6bdbb34009b3 100644 > --- a/sound/usb/card.c > +++ b/sound/usb/card.c > @@ -658,6 +658,12 @@ static int usb_audio_probe(struct usb_interface *intf, > } > > dev_set_drvdata(&dev->dev, chip); > + /* > + *ALSA: usb-audio: Add prevent wakeup from s3 state trig by Lenovo > + *ThinkCentre TI024Gen3 usb-audio > + */ > + if ((usb_id->idVendor == 0x17ef) && (usb_id->idProduct == 0xa012)) > + device_set_wakeup_enable(＆dev->dev, 0); Here it's no proper ASCII letter, and this must be broken. Please check the actual patch before submitting. In anyway, before going further, I'd like to hear from other people whether this is really mandatory and appropriate. And whether it's specific to that device, too (not other Lenovo devices?) thanks, Takashi