From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 7/16] ALSA: VIA HDA: Modify
	notify_aa_path_ctls() function
Date: Mon, 21 Mar 2011 12:08:19 +0100
Message-ID: <s5h39mgspcs.wl%tiwai@suse.de>
References: <4D86FE5F.9030106@viatech.com.cn>
	<alpine.LNX.2.00.1103210832030.4805@eeebox2.perex-int.cz>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (cantor.suse.de [195.135.220.2])
	by alsa0.perex.cz (Postfix) with ESMTP id 8722A24430
	for <alsa-devel@alsa-project.org>; Mon, 21 Mar 2011 12:08:23 +0100 (CET)
In-Reply-To: <alpine.LNX.2.00.1103210832030.4805@eeebox2.perex-int.cz>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org, HaraldWelte@viatech.com, Lydia Wang <lydiawang@viatech.com.cn>
List-Id: alsa-devel@alsa-project.org

At Mon, 21 Mar 2011 08:32:43 +0100 (CET),
Jaroslav Kysela wrote:
> 
> On Mon, 21 Mar 2011, Lydia Wang wrote:
> 
> > From: Lydia Wang <lydiawang@viatech.com.cn>
> > Subject: ALSA: VIA HDA: Modify notify_aa_path_ctls() function.
> >
> > Modify notify_aa_path_ctls() function to get volume control items name
> > dynamically instead of by giving static item name.
> 
> This code looks ugly to me. If you like to have a dynamic set of notified 
> controls, create one using snd_array in via_spec.

Agreed.  The current code is too fragile.


thanks,

Takashi