Re: [PATCH] buffersize and constraints on pmac

[Takashi Iwai <tiwai@suse.de>]

At Wed, 15 Dec 2004 22:40:03 +0100 (CET),
<danny@mailmij.org> wrote:
> 
> On Wed, 15 Dec 2004, Takashi Iwai wrote:
> 
> > At Wed, 15 Dec 2004 21:31:30 +0100 (CET),
> > <danny@mailmij.org> wrote:
> > > 
> > > +       /* constraints to fix choppy sound */
> > > +       snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_PERIODS, 3, UINT_MAX);
> > 
> > This should be specified in snd_pmac_playback.periods_min and
> > snd_pmac_capture.periods_min statically.
> duh...ofcourse, sorries :)
> 
> > 
> > Others look fine.  Could you regenerate the patch?
> > 
> here you are..I wondered btw, why PMAC_MAX_FRAGS is set to what it is (32) 
> since for me higher values seem to work as well. But since it doesn't seem 
> broken I didn't touch it:)

Yep, usually 32 periods are enough :)

I applied your patch now to CVS, but it was done manually because your
mailer broke the patch with tab/space conversion.  Please check the
CVS tree later whether I did correctly.


thanks,

Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/