Re: [PATCH] pmac mixer update from shadow register on resume and switching DRC on headphone plug

[Takashi Iwai <tiwai@suse.de>]

At Fri, 30 Jul 2004 16:56:16 +0200,
Rene Rebe wrote:
> 
> Hi all,
> 
> the attached patch improved the pmac driver by implementing updating the 
> mixer from the shadow register after a resume or headphone interrupt, as 
> well as automatically selecting DRC on headphone plug.
> 
> For normal line-out one does not want the DRC, but it should 
> automatically be reenabled after the headphone is unplugged: Otherwise 
> the power to the internal speakers is high enought to destroy them 
> (happend once to my iBook - when it still had warrenty ... ;-)
> 
> I needed a work-queue / task-queue since it can not be done in the 
> interrupt context - this is done in the way the OSS driver does it, too. 
> I hope this is acceptable.

That's fine, but we keep 2.6 clean from older kernel codes.
The mixed code is the result after patch, which you can find in
alsa-driver tree as *.patch file.

Could you make them separate, and send the patch to tumbler.c and the
new tumber.patch?
i.e. alsa-kernel/ppc/tumbler.c contains 2.6-only code and the stuff
within "#if LINUX_VERSION_CODE < KERNEL_VERSION(2,5,0)" is added by
alsa-driver/ppc/tumbler.patch.


Takashi


-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com