From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: USB Audio problems Date: Fri, 21 Nov 2003 11:37:51 +0100 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <3FBBC461.1020006@opersys.com> <3FBC560B.7040104@opersys.com> <3FBD23E9.1060609@opersys.com> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <3FBD23E9.1060609@opersys.com> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: To: karim@opersys.com Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Thu, 20 Nov 2003 15:28:25 -0500, Karim Yaghmour wrote: > > > Takashi Iwai wrote: > > it'd be better to clean unlink_mask in the complete callback for the > > case you use async unlink mode (see below). > > and, the check of active_mask should be done in prepare callback, not > > in the trigger callback. the trigger callback must be as short as > > possible. we can put deactivate_urbs() in prepre callback so that the > > urbs become clean before starting streams. > > Sounds right. already changed on cvs :) will be reflected to 1.0.0-test2. > > (but still we have a problem of async unlink because prepare callback > > is also in the spinlocked context.) > > Would it be fair to say that this driver requires some major rework? yes. not much in usbaudio.c itself but in the core PCM part. Takashi ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/