All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Tim Goetze <tim@quitte.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: Testers of M-Audio Delta/Audiophile cards wanted
Date: Thu, 19 Sep 2002 17:13:28 +0200	[thread overview]
Message-ID: <s5h3cs6qag7.wl@alsa2.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.21.0209191705100.595-100000@summer.quitte>

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

At Thu, 19 Sep 2002 17:06:08 +0200 (CEST),
Tim Goetze wrote:
> 
> much simpler. you did a c++ style auto variable allocation, declare
> 'ak' at the start of snd_ice1712_ews_init and it compiles cleanly.

oops, never noticed that.  i relied too much upon the compiler.
well, this means that gcc-3.2 accepts this style as normal C...?

will be fixed once when cvs server is repaired.

thanks,


Takashi

[-- Attachment #2: ews-fix.dif --]
[-- Type: application/octet-stream, Size: 718 bytes --]

Index: alsa-kernel/pci/ice1712/ews.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/ice1712/ews.c,v
retrieving revision 1.3
diff -u -r1.3 ews.c
--- alsa-kernel/pci/ice1712/ews.c	16 Sep 2002 10:12:31 -0000	1.3
+++ alsa-kernel/pci/ice1712/ews.c	19 Sep 2002 15:09:01 -0000
@@ -325,6 +325,7 @@
 static int __devinit snd_ice1712_ews_init(ice1712_t *ice)
 {
 	int err;
+	ak4524_t *ak;
 
 	/* set the analog DACs */
 	switch (ice->eeprom.subvendor) {
@@ -400,7 +401,7 @@
 	}
 
 	/* analog section */
-	ak4524_t *ak = &ice->ak4524;
+	ak = &ice->ak4524;
 	switch (ice->eeprom.subvendor) {
 	case ICE1712_SUBDEVICE_EWS88MT:
 		ak->num_adcs = ak->num_dacs = 8;

  reply	other threads:[~2002-09-19 15:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-19 12:49 Testers of M-Audio Delta/Audiophile cards wanted Takashi Iwai
2002-09-19 14:35 ` Tim Goetze
2002-09-19 14:47   ` Takashi Iwai
2002-09-19 14:50     ` Tim Goetze
2002-09-19 14:59       ` Takashi Iwai
2002-09-19 15:06         ` Tim Goetze
2002-09-19 15:13           ` Takashi Iwai [this message]
2002-09-19 15:16             ` Jaroslav Kysela
2002-09-19 15:19             ` Tim Goetze
2002-09-20  9:08               ` Clemens Ladisch
2002-09-23 14:43                 ` [ot] " Tim Goetze
2002-09-19 17:54 ` James Tappin
2002-09-20  9:59 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h3cs6qag7.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tim@quitte.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.