From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: dmix, snd_pcm_drain(), SND_PCM_NONBLOCK - bug? Date: Mon, 20 Mar 2017 08:38:12 +0100 Message-ID: References: <20170316122336.GA7038@swift.blarg.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 0D510265823 for ; Mon, 20 Mar 2017 08:38:12 +0100 (CET) In-Reply-To: <20170316122336.GA7038@swift.blarg.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Max Kellermann Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Thu, 16 Mar 2017 13:23:36 +0100, Max Kellermann wrote: > > Hi, > > I have received a bug report for the Music Player Daemon which > complains about a freezing MPD process, after I switched MPD's ALSA > output to non-blocking mode: > > https://bugs.musicpd.org/view.php?id=4662 > > This happens when snd_pcm_drain() is used on a dmix PCM which is in > SND_PCM_NONBLOCK mode. snd_pcm_drain() will be called repeatedly, > because ALSA's file descriptor is always ready. > > According to my research, the bug is in __snd_pcm_dmix_drain(). This > function always returns -EAGAIN when SND_PCM_NONBLOCK is set: > > if (pcm->mode & SND_PCM_NONBLOCK) > return -EAGAIN; > > This comes very early in the function, before any other relevant > checks. It can never finish that way, and calling it again at any > time will never do anything. Thus, snd_pcm_drain() appears to be > broken in non-blocking mode. > > Or am I misunderstanding how snd_pcm_drain() is supposed to be used in > non-blocking mode? Yeah, the code is obviously wrong. And it seems that now Jaroslav already fixed the issue in git repo. Please give it a try. thanks, Takashi