From: Takashi Iwai <tiwai@suse.de>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v3 00/13] alsa-lib topology support
Date: Thu, 30 Jul 2015 17:13:46 +0200 [thread overview]
Message-ID: <s5h4mklr845.wl-tiwai@suse.de> (raw)
In-Reply-To: <1438188325-11553-1-git-send-email-liam.r.girdwood@linux.intel.com>
On Wed, 29 Jul 2015 18:45:12 +0200,
Liam Girdwood wrote:
>
> This series adds support for parsing topology data text files and converting
> to the binary topology format accepted by the kernel.
>
> Changes since V2 :-
>
> o Added documentation in doxygen format describing API and text file format.
> o use SNDERR macro for error reporting.
> o Added text copy helper.
> o Make all parsed keywords lowercase
> o Assignment for some structure copies instead of memcpy().
> o Fixed the private data parser to handle byte, short and word data.
>
> Changes since V1 :-
>
> o Terminate all strncpy() strings with NULL.
> o Use snd_pcm_format_value() instead of local lookup.
> o Set a maximum size for private data files.
> o Set capture/playback stream direction for new PCMs
> o Only set TLV access flags for TLV CTLs.
>
>
> Liam Girdwood (13):
> topology: uapi: Add UAPI headers for topology ABI
> topology: Add topology core parser.
> topology: Add text section parser.
> topology: Add PCM parser.
> topology: Add operations parser
> topology: Add private data parser
> topology: Add DAPM object parser
> topology: Add CTL parser
> topology: Add Channel map parser.
> topology: Add binary file builder.
> topology: autotools: Add build support for topology core
> topology: doxygen: Add doxygen support for topology core.
> conf: topology: Add topology file for broadwell audio DSP
I merged all patches now together with a couple of trivial fixes.
(Also fixed the bisectionability in patches 11 and 13).
thanks,
Takashi
>
> configure.ac | 11 +-
> doc/doxygen.cfg.in | 7 +-
> doc/index.doxygen | 1 +
> include/Makefile.am | 4 +
> include/sound/Makefile.am | 3 +-
> include/sound/asoc.h | 388 ++++++++++++++++++
> include/sound/tlv.h | 23 ++
> include/topology.h | 497 ++++++++++++++++++++++
> src/Makefile.am | 7 +
> src/conf/Makefile.am | 2 +-
> src/conf/topology/Makefile.am | 1 +
> src/conf/topology/broadwell/Makefile.am | 4 +
> src/conf/topology/broadwell/broadwell.conf | 375 +++++++++++++++++
> src/topology/Makefile.am | 19 +
> src/topology/builder.c | 327 +++++++++++++++
> src/topology/channel.c | 122 ++++++
> src/topology/ctl.c | 613 +++++++++++++++++++++++++++
> src/topology/dapm.c | 562 +++++++++++++++++++++++++
> src/topology/data.c | 396 ++++++++++++++++++
> src/topology/elem.c | 187 +++++++++
> src/topology/ops.c | 84 ++++
> src/topology/parser.c | 359 ++++++++++++++++
> src/topology/pcm.c | 639 +++++++++++++++++++++++++++++
> src/topology/text.c | 88 ++++
> src/topology/tplg_local.h | 234 +++++++++++
> 25 files changed, 4948 insertions(+), 5 deletions(-)
> create mode 100644 include/sound/asoc.h
> create mode 100644 include/sound/tlv.h
> create mode 100644 include/topology.h
> create mode 100644 src/conf/topology/Makefile.am
> create mode 100644 src/conf/topology/broadwell/Makefile.am
> create mode 100644 src/conf/topology/broadwell/broadwell.conf
> create mode 100644 src/topology/Makefile.am
> create mode 100644 src/topology/builder.c
> create mode 100644 src/topology/channel.c
> create mode 100644 src/topology/ctl.c
> create mode 100644 src/topology/dapm.c
> create mode 100644 src/topology/data.c
> create mode 100644 src/topology/elem.c
> create mode 100644 src/topology/ops.c
> create mode 100644 src/topology/parser.c
> create mode 100644 src/topology/pcm.c
> create mode 100644 src/topology/text.c
> create mode 100644 src/topology/tplg_local.h
>
> --
> 2.1.4
>
next prev parent reply other threads:[~2015-07-30 15:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 16:45 [PATCH v3 00/13] alsa-lib topology support Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 01/13] topology: uapi: Add UAPI headers for topology ABI Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 02/13] topology: Add topology core parser Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 03/13] topology: Add text section parser Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 04/13] topology: Add PCM parser Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 05/13] topology: Add operations parser Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 06/13] topology: Add private data parser Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 07/13] topology: Add DAPM object parser Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 08/13] topology: Add CTL parser Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 09/13] topology: Add Channel map parser Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 10/13] topology: Add binary file builder Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 11/13] topology: autotools: Add build support for topology core Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 12/13] topology: doxygen: Add doxygen " Liam Girdwood
2015-07-29 16:45 ` [PATCH v3 13/13] conf: topology: Add topology file for broadwell audio DSP Liam Girdwood
2015-07-30 15:13 ` Takashi Iwai [this message]
2015-07-31 9:27 ` [PATCH v3 00/13] alsa-lib topology support Liam Girdwood
2015-07-31 15:31 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4mklr845.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.