From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 1/3] ALSA: hdspm - Fix MADI channel format in the status ioctl Date: Mon, 31 Oct 2011 10:05:20 +0100 Message-ID: References: <1319745474-31542-1-git-send-email-adi@drcomp.erfurt.thur.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1319745474-31542-1-git-send-email-adi@drcomp.erfurt.thur.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Adrian Knoth Cc: alsa-devel@alsa-project.org, patch@alsa-project.org List-Id: alsa-devel@alsa-project.org At Thu, 27 Oct 2011 21:57:52 +0200, Adrian Knoth wrote: > > SNDRV_HDSPM_IOCTL_GET_STATUS is supposed to query the current card > status, so we have to return what we receive on the MADI wire (RX), not > what we transmit (TX) to others. The latter is a config item to be > queried via SNDRV_HDSPM_IOCTL_GET_CONFIG. > > Signed-off-by: Adrian Knoth Applied all three patches now. Thanks. Takashi > diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c > index 6e2f7ef..60a0b7d 100644 > --- a/sound/pci/rme9652/hdspm.c > +++ b/sound/pci/rme9652/hdspm.c > @@ -6253,7 +6253,7 @@ static int snd_hdspm_hwdep_ioctl(struct snd_hwdep *hw, struct file *file, > status.card_specific.madi.madi_input = > (statusregister & HDSPM_AB_int) ? 1 : 0; > status.card_specific.madi.channel_format = > - (statusregister & HDSPM_TX_64ch) ? 1 : 0; > + (statusregister & HDSPM_RX_64ch) ? 1 : 0; > /* TODO: Mac driver sets it when f_s>48kHz */ > status.card_specific.madi.frame_format = 0; > > -- > 1.7.7.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >