From: Takashi Iwai <tiwai@suse.de>
To: Dave Jones <davej@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove pointless code from ALSA emu10k1 midi driver.
Date: Wed, 01 Sep 2004 20:06:46 +0200 [thread overview]
Message-ID: <s5h4qmhzww9.wl@alsa2.suse.de> (raw)
In-Reply-To: <200409011551.i81FpMwt000680@delerium.codemonkey.org.uk>
Well it's not ALSA emu10k1 but OSS ;)
Takashi
At Wed, 1 Sep 2004 16:51:22 +0100,
Dave Jones wrote:
>
> Spotted with the source checker from Coverity.com.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
>
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/sound/oss/emu10k1/midi.c linux-2.6/sound/oss/emu10k1/midi.c
> --- bk-linus/sound/oss/emu10k1/midi.c 2004-08-09 13:12:18.000000000 +0100
> +++ linux-2.6/sound/oss/emu10k1/midi.c 2004-08-23 14:08:26.000000000 +0100
> @@ -320,7 +320,6 @@ static ssize_t emu10k1_midi_write(struct
> {
> struct emu10k1_mididevice *midi_dev = (struct emu10k1_mididevice *) file->private_data;
> struct midi_hdr *midihdr;
> - ssize_t ret = 0;
> unsigned long flags;
>
> DPD(4, "emu10k1_midi_write(), count=%#x\n", (u32) count);
> @@ -344,7 +343,7 @@ static ssize_t emu10k1_midi_write(struct
> if (copy_from_user(midihdr->data, buffer, count)) {
> kfree(midihdr->data);
> kfree(midihdr);
> - return ret ? ret : -EFAULT;
> + return -EFAULT;
> }
>
> spin_lock_irqsave(&midi_spinlock, flags);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2004-09-01 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 15:51 [PATCH] Remove pointless code from ALSA emu10k1 midi driver Dave Jones
2004-09-01 18:06 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4qmhzww9.wl@alsa2.suse.de \
--to=tiwai@suse.de \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.