From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: An driver error when I using aplay! Date: Mon, 07 Jun 2004 16:18:55 +0200 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: <20040607092522.29704.qmail@web15206.mail.bjs.yahoo.com> <20040607111729.A23059@flint.arm.linux.org.uk> <20040607140817.A28526@flint.arm.linux.org.uk> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20040607145113.B28526@flint.arm.linux.org.uk> Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Russell King Cc: Jaroslav Kysela , Roc Wu , Clemens Ladisch , Alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Mon, 7 Jun 2004 14:51:13 +0100, Russell King wrote: > > On Mon, Jun 07, 2004 at 03:40:23PM +0200, Takashi Iwai wrote: > > At Mon, 7 Jun 2004 14:08:17 +0100, > > Russell King wrote: > > > > > > On Mon, Jun 07, 2004 at 02:45:20PM +0200, Takashi Iwai wrote: > > > > i guess so, too. as you can see in the original post, the error > > > > returned from hw_params callback (sample not available), thus it > > > > doesn't call trigger(START) callback yet at all. > > > > > > If we never got past hw_params() then we didn't enable the IO, > > > and it must be that something else in the system fiddled with > > > the chip and set it incorrectly. > > > > > > > unfurtunately i can't tell any more unless i read the driver code. > > > > where can i find the code? > > > > > > I never officially released the driver, though it was part of the > > > old -rmk patches back in the 2.6.0-test era. Where Roc has got > > > the source from, and what modifications have been made is anyones > > > guess. > > > > Roc sent me the code now :) > > > > after a quick look, it seems that txcr isn't initialized in the open > > callback but only in hw_params callback (which was never called in > > this case). > > Why should it be explicitly initialised? Take a moment to consider > what guarantees snd_card_new() gives for the allocated memory. Yep, > that's right - it's initialised to zero. So, chan->txcr is already > initialised to zero. You're right. The error was not txcr, but in another WARN_ON() for checking chan->tx_substream (line 404)! (Russell, you mislead this, too ;) The reason is same -- since hw_params is not called, chan->tx_substream is not set, too. Takashi ------------------------------------------------------- This SF.Net email is sponsored by the new InstallShield X. >>From Windows to Linux, servers to mobile, InstallShield X is the one installation-authoring solution that does it all. Learn more and evaluate today! http://www.installshield.com/Dev2Dev/0504