From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Patch to fix Pax/Grsecurity Problems Date: Mon, 26 Jan 2004 16:58:57 +0100 Sender: alsa-devel-admin@lists.sourceforge.net Message-ID: References: Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Clemens Ladisch Cc: siti_veni@lycos.com, alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Mon, 26 Jan 2004 14:45:49 +0100 (MET), Clemens Ladisch wrote: > > Takashi Iwai wrote: > > Stephen Cook wrote: > > > > > > >> - qsort(hctl->pelems, hctl->count, sizeof(*hctl->pelems), compar); > > > >> + > > > >> + pthread_mutex_lock(&sync_lock); > > > >> + compare_hctl = hctl; > > > >> + qsort(hctl->pelems, hctl->count, sizeof(*hctl->pelems), hctl_compare); > > > >> + pthread_mutex_unlock(&sync_lock); > > > > > > I hope I don't sound to persistent but I am just wondering when this > > > patch is going to be merged or if there is anything I can do to help > > > speed it up. Such as any changes to the patch etc. > > > > well, i'm also waiting for the response from others. > > Looks fine. > > We're already dependent on pthreads, and qsort doesn't pass extra > parameters, so I don't see any better way to do this. > ("Let's write our own sorting routine" is not better IMNSHO.) agreed. it's on cvs now. (will be included in 1.0.2 release.) thanks, Takashi ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn