From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F10C5519F for ; Wed, 18 Nov 2020 07:35:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A60C224656 for ; Wed, 18 Nov 2020 07:35:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="j5xPpLTi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A60C224656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EB9D61718; Wed, 18 Nov 2020 08:34:43 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EB9D61718 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1605684934; bh=4Ot/GLEYpwpIUt+eg5I50IrRDpdg9KK+mVzz+222Jh0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=j5xPpLTirRXDtG4A/Md5d9g9YKceYM0mqfaIpSa5duZyviNFjTc9YD0VcuLYB8eMs EnoEKKQvmKc7eR+Nxb7X2zAvuiffRMVG9kgr1RODqZf9gE7kyqwVnEYC9UIu2ed7h7 I7l5LgRv+XQYNmtLot2YhnHjWi/SoTdAYtRHlM4c= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 689F0F80168; Wed, 18 Nov 2020 08:34:43 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id C9E18F8016C; Wed, 18 Nov 2020 08:34:40 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BAE9AF80158 for ; Wed, 18 Nov 2020 08:34:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BAE9AF80158 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5041EABDE; Wed, 18 Nov 2020 07:34:26 +0000 (UTC) Date: Wed, 18 Nov 2020 08:34:25 +0100 Message-ID: From: Takashi Iwai To: Macpaul Lin Subject: Re: [PATCH v3] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET In-Reply-To: <1605677166.23663.4.camel@mtkswgap22> References: <1604996266.2817.1.camel@mtkswgap22> <1604999048-20294-1-git-send-email-macpaul.lin@mediatek.com> <1605677166.23663.4.camel@mtkswgap22> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: "alsa-devel@alsa-project.org" , "linux-usb@vger.kernel.org" , wsd_upstream , Christopher Swenson , "linux-kernel@vger.kernel.org" , Macpaul Lin , "Eddie Hung \(=?UTF-8?B?5rSq5q2j6ZGr?=\)" , Takashi Iwai , "stable@vger.kernel.org" , "Chunfeng Yun \(=?UTF-8?B?5LqR5pil5bOw?=\)" , Alexander Tsoy , "linux-mediatek@lists.infradead.org" , Nick Kossifidis , Matthias Brugger , Nicola Lunghi , "linux-arm-kernel@lists.infradead.org" , "Ainge Hsu \(=?UTF-8?B?5b6Q5ben5a6c?=\)" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 18 Nov 2020 06:26:06 +0100, Macpaul Lin wrote: > > On Tue, 2020-11-10 at 17:04 +0800, Macpaul Lin wrote: > > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports > > 96khz. However there will be some random issue under 96khz. > > Not sure if there is any alternate setting could be applied. > > Hence 48khz is suggested to be applied at this moment. > > > > Signed-off-by: Macpaul Lin > > Signed-off-by: Eddie Hung > > Cc: stable@vger.kernel.org > > --- > > Changes for v2: > > - Fix build error. > > - Add Cc: stable@vger.kernel.org > > Changes for v3: > > - Replace "udev" with "chip->dev" according to Takashi's suggestion. Thanks. > > > > sound/usb/format.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/sound/usb/format.c b/sound/usb/format.c > > index 1b28d01..0aff774 100644 > > --- a/sound/usb/format.c > > +++ b/sound/usb/format.c > > @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof > > (chip->usb_id == USB_ID(0x041e, 0x4064) || > > chip->usb_id == USB_ID(0x041e, 0x4068))) > > rate = 8000; > > + /* Huawei headset can't support 96kHz fully */ > > + if (rate == 96000 && > > + chip->usb_id == USB_ID(0x12d1, 0x3a07) && > > + le16_to_cpu(chip->dev->descriptor.bcdDevice) == 0x49) > > + continue; > > > > fp->rate_table[fp->nr_rates] = rate; > > if (!fp->rate_min || rate < fp->rate_min) > > Sorry for bothering again, please hold-on this patch. > I'm still trying to clarify if there is another approach for this > interoperability issue. > I'll update this thread once the result has came out. OK, thanks for information. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A99F6C5519F for ; Wed, 18 Nov 2020 07:34:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03995221E9 for ; Wed, 18 Nov 2020 07:34:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aZmsaVqX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 03995221E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=saWydVcf47fplI7+651kMYXuGvW6CMbfwJ5wdRUkwWA=; b=aZmsaVqXv8ciSKhzDPTWMtmB2 IS2lCAXJFEnxkKFr6b4jWaBq66NSgmWXMQ+ekgvzn3jT3p3/Qqc7UbU5UsT2kWr0YcG4EQ9mO4BbD nu8j0bD2YmaI+/HDfnzd9It7k0hZH95Lx8UmCw1zTQY0A0apLiQ9uUB0l5ZIk/7b+Rt6/lPonoor3 lbz+Y8FKjOBQrD8Y7jeU5e4RGX4OhwgCu8U93E5UWozJZXYeHPu1zRd4Vra+49n/f2FFbYAAxR21C TvUqANujBLFN8qatibVfSIulYMg33zOM7WEPYQgSkZEuAxTdk6DGnketK29uGqeooPNylReUm21Li EGLtQtwgw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfHz6-0007rD-Qv; Wed, 18 Nov 2020 07:34:32 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfHz2-0007qQ-TF; Wed, 18 Nov 2020 07:34:29 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5041EABDE; Wed, 18 Nov 2020 07:34:26 +0000 (UTC) Date: Wed, 18 Nov 2020 08:34:25 +0100 Message-ID: From: Takashi Iwai To: Macpaul Lin Subject: Re: [PATCH v3] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET In-Reply-To: <1605677166.23663.4.camel@mtkswgap22> References: <1604996266.2817.1.camel@mtkswgap22> <1604999048-20294-1-git-send-email-macpaul.lin@mediatek.com> <1605677166.23663.4.camel@mtkswgap22> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201118_023429_057879_AAD18C0D X-CRM114-Status: GOOD ( 25.02 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "alsa-devel@alsa-project.org" , "linux-usb@vger.kernel.org" , wsd_upstream , Christopher Swenson , "linux-kernel@vger.kernel.org" , Macpaul Lin , "Eddie Hung \(=?UTF-8?B?5rSq5q2j6ZGr?=\)" , Takashi Iwai , "stable@vger.kernel.org" , Jaroslav Kysela , "Chunfeng Yun \(=?UTF-8?B?5LqR5pil5bOw?=\)" , Alexander Tsoy , "linux-mediatek@lists.infradead.org" , Nick Kossifidis , Matthias Brugger , Nicola Lunghi , "linux-arm-kernel@lists.infradead.org" , "Ainge Hsu \(=?UTF-8?B?5b6Q5ben5a6c?=\)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 18 Nov 2020 06:26:06 +0100, Macpaul Lin wrote: > > On Tue, 2020-11-10 at 17:04 +0800, Macpaul Lin wrote: > > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports > > 96khz. However there will be some random issue under 96khz. > > Not sure if there is any alternate setting could be applied. > > Hence 48khz is suggested to be applied at this moment. > > > > Signed-off-by: Macpaul Lin > > Signed-off-by: Eddie Hung > > Cc: stable@vger.kernel.org > > --- > > Changes for v2: > > - Fix build error. > > - Add Cc: stable@vger.kernel.org > > Changes for v3: > > - Replace "udev" with "chip->dev" according to Takashi's suggestion. Thanks. > > > > sound/usb/format.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/sound/usb/format.c b/sound/usb/format.c > > index 1b28d01..0aff774 100644 > > --- a/sound/usb/format.c > > +++ b/sound/usb/format.c > > @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof > > (chip->usb_id == USB_ID(0x041e, 0x4064) || > > chip->usb_id == USB_ID(0x041e, 0x4068))) > > rate = 8000; > > + /* Huawei headset can't support 96kHz fully */ > > + if (rate == 96000 && > > + chip->usb_id == USB_ID(0x12d1, 0x3a07) && > > + le16_to_cpu(chip->dev->descriptor.bcdDevice) == 0x49) > > + continue; > > > > fp->rate_table[fp->nr_rates] = rate; > > if (!fp->rate_min || rate < fp->rate_min) > > Sorry for bothering again, please hold-on this patch. > I'm still trying to clarify if there is another approach for this > interoperability issue. > I'll update this thread once the result has came out. OK, thanks for information. Takashi _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF6DC6369E for ; Wed, 18 Nov 2020 07:34:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31E2D2466D for ; Wed, 18 Nov 2020 07:34:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726506AbgKRHe2 (ORCPT ); Wed, 18 Nov 2020 02:34:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:48366 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725794AbgKRHe2 (ORCPT ); Wed, 18 Nov 2020 02:34:28 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5041EABDE; Wed, 18 Nov 2020 07:34:26 +0000 (UTC) Date: Wed, 18 Nov 2020 08:34:25 +0100 Message-ID: From: Takashi Iwai To: Macpaul Lin Cc: Takashi Iwai , Jaroslav Kysela , Matthias Brugger , Alexander Tsoy , "Nicola Lunghi" , Christopher Swenson , Nick Kossifidis , "alsa-devel@alsa-project.org" , Ainge Hsu (=?UTF-8?B?5b6Q5ben5a6c?=) , Eddie Hung (=?UTF-8?B?5rSq5q2j6ZGr?=) , Chunfeng Yun (=?UTF-8?B?5LqR5pil5bOw?=) , wsd_upstream , Macpaul Lin , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-usb@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "stable@vger.kernel.org" Subject: Re: [PATCH v3] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET In-Reply-To: <1605677166.23663.4.camel@mtkswgap22> References: <1604996266.2817.1.camel@mtkswgap22> <1604999048-20294-1-git-send-email-macpaul.lin@mediatek.com> <1605677166.23663.4.camel@mtkswgap22> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, 18 Nov 2020 06:26:06 +0100, Macpaul Lin wrote: > > On Tue, 2020-11-10 at 17:04 +0800, Macpaul Lin wrote: > > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports > > 96khz. However there will be some random issue under 96khz. > > Not sure if there is any alternate setting could be applied. > > Hence 48khz is suggested to be applied at this moment. > > > > Signed-off-by: Macpaul Lin > > Signed-off-by: Eddie Hung > > Cc: stable@vger.kernel.org > > --- > > Changes for v2: > > - Fix build error. > > - Add Cc: stable@vger.kernel.org > > Changes for v3: > > - Replace "udev" with "chip->dev" according to Takashi's suggestion. Thanks. > > > > sound/usb/format.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/sound/usb/format.c b/sound/usb/format.c > > index 1b28d01..0aff774 100644 > > --- a/sound/usb/format.c > > +++ b/sound/usb/format.c > > @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof > > (chip->usb_id == USB_ID(0x041e, 0x4064) || > > chip->usb_id == USB_ID(0x041e, 0x4068))) > > rate = 8000; > > + /* Huawei headset can't support 96kHz fully */ > > + if (rate == 96000 && > > + chip->usb_id == USB_ID(0x12d1, 0x3a07) && > > + le16_to_cpu(chip->dev->descriptor.bcdDevice) == 0x49) > > + continue; > > > > fp->rate_table[fp->nr_rates] = rate; > > if (!fp->rate_min || rate < fp->rate_min) > > Sorry for bothering again, please hold-on this patch. > I'm still trying to clarify if there is another approach for this > interoperability issue. > I'll update this thread once the result has came out. OK, thanks for information. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D93AC5519F for ; Wed, 18 Nov 2020 07:35:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D85FA221E9 for ; Wed, 18 Nov 2020 07:35:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XsvNLjzm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D85FA221E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KYL0rA7rxPx+aAjsRVwcFS55EnnU/6jQWtG0OozADDg=; b=XsvNLjzmWVKEO7dGxKA6acjx2 RpqRCYC6RXS7x17SPXA0lY/zOrQI99qqYabMHphd7FVSRVZatN2palC7rAyJeKlH5zXQYSqvR+ArS 6ew8/acp3nFe9LW/WAmGU/SOMTM/B045KD65OqZU/FnKjAuzjVtp5q6DMC5PnQPhBt3SN96KLzd9Y FvbMlMx8RW0f80O6t2YwrXKaoV+Ej3wG5W48IMm7dNR9GAKnlPkU3m+i8N7pXj0xwLdZ2b1M6DCYD Q3z++qJVG60e7VYXu7N/ewDoxqgJb687L+2s4DZ+Jk8XIrHZtSYLKsQU9J9h011JOK2f540edRVsO o8tofiAQw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfHz5-0007qz-HW; Wed, 18 Nov 2020 07:34:31 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfHz2-0007qQ-TF; Wed, 18 Nov 2020 07:34:29 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5041EABDE; Wed, 18 Nov 2020 07:34:26 +0000 (UTC) Date: Wed, 18 Nov 2020 08:34:25 +0100 Message-ID: From: Takashi Iwai To: Macpaul Lin Subject: Re: [PATCH v3] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET In-Reply-To: <1605677166.23663.4.camel@mtkswgap22> References: <1604996266.2817.1.camel@mtkswgap22> <1604999048-20294-1-git-send-email-macpaul.lin@mediatek.com> <1605677166.23663.4.camel@mtkswgap22> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201118_023429_057879_AAD18C0D X-CRM114-Status: GOOD ( 25.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "alsa-devel@alsa-project.org" , "linux-usb@vger.kernel.org" , wsd_upstream , Christopher Swenson , "linux-kernel@vger.kernel.org" , Macpaul Lin , "Eddie Hung \(=?UTF-8?B?5rSq5q2j6ZGr?=\)" , Takashi Iwai , "stable@vger.kernel.org" , Jaroslav Kysela , "Chunfeng Yun \(=?UTF-8?B?5LqR5pil5bOw?=\)" , Alexander Tsoy , "linux-mediatek@lists.infradead.org" , Nick Kossifidis , Matthias Brugger , Nicola Lunghi , "linux-arm-kernel@lists.infradead.org" , "Ainge Hsu \(=?UTF-8?B?5b6Q5ben5a6c?=\)" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 18 Nov 2020 06:26:06 +0100, Macpaul Lin wrote: > > On Tue, 2020-11-10 at 17:04 +0800, Macpaul Lin wrote: > > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports > > 96khz. However there will be some random issue under 96khz. > > Not sure if there is any alternate setting could be applied. > > Hence 48khz is suggested to be applied at this moment. > > > > Signed-off-by: Macpaul Lin > > Signed-off-by: Eddie Hung > > Cc: stable@vger.kernel.org > > --- > > Changes for v2: > > - Fix build error. > > - Add Cc: stable@vger.kernel.org > > Changes for v3: > > - Replace "udev" with "chip->dev" according to Takashi's suggestion. Thanks. > > > > sound/usb/format.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/sound/usb/format.c b/sound/usb/format.c > > index 1b28d01..0aff774 100644 > > --- a/sound/usb/format.c > > +++ b/sound/usb/format.c > > @@ -217,6 +217,11 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof > > (chip->usb_id == USB_ID(0x041e, 0x4064) || > > chip->usb_id == USB_ID(0x041e, 0x4068))) > > rate = 8000; > > + /* Huawei headset can't support 96kHz fully */ > > + if (rate == 96000 && > > + chip->usb_id == USB_ID(0x12d1, 0x3a07) && > > + le16_to_cpu(chip->dev->descriptor.bcdDevice) == 0x49) > > + continue; > > > > fp->rate_table[fp->nr_rates] = rate; > > if (!fp->rate_min || rate < fp->rate_min) > > Sorry for bothering again, please hold-on this patch. > I'm still trying to clarify if there is another approach for this > interoperability issue. > I'll update this thread once the result has came out. OK, thanks for information. Takashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel